aws-privateca-issuer
aws-privateca-issuer copied to clipboard
feat: Support disabling Kubernetes client side rate limiting
This should theoretically resolve #334.
Note that I haven't had the chance to test this at all - I believe it works (and I based a good bit of my work on the changes in https://github.com/cert-manager/istio-csr/pull/352 which does the same thing for istio-csr), but I haven't actually proven that out end-to-end by adding unit and integration tests because I don't really have a deep understanding of the test suite here.
This PR includes:
- new value in Helm values,
disableClientSideRateLimiting - corresponding new command line option
- Using this new option to set
config.QPSandconfig.Burstfor the Kubernetes REST client
Hi, we're currently in the process of testing this PR to make sure everything works properly! We're currently not seeing any improvements by enabling this so looking into why that may be.
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment