aws-privateca-issuer icon indicating copy to clipboard operation
aws-privateca-issuer copied to clipboard

feat: Support disabling Kubernetes client side rate limiting

Open hexalellogram opened this issue 1 year ago • 2 comments

This should theoretically resolve #334.

Note that I haven't had the chance to test this at all - I believe it works (and I based a good bit of my work on the changes in https://github.com/cert-manager/istio-csr/pull/352 which does the same thing for istio-csr), but I haven't actually proven that out end-to-end by adding unit and integration tests because I don't really have a deep understanding of the test suite here.

This PR includes:

  • new value in Helm values, disableClientSideRateLimiting
  • corresponding new command line option
  • Using this new option to set config.QPS and config.Burst for the Kubernetes REST client

hexalellogram avatar Aug 15 '24 22:08 hexalellogram

Hi, we're currently in the process of testing this PR to make sure everything works properly! We're currently not seeing any improvements by enabling this so looking into why that may be.

ARichman555 avatar Aug 22 '24 19:08 ARichman555

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

cert-manager-prow[bot] avatar Sep 23 '24 17:09 cert-manager-prow[bot]