aws-privateca-issuer
aws-privateca-issuer copied to clipboard
fix: HPA syntax, allow v2 API
HPA had apparently an additional field (checked v1 and v2 and none have namespace
under scaleTargetRef.
Support for HPA v2 added if supported by the target cluster.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Good catch, I don't see namespace here either: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#crossversionobjectreference-v2-autoscaling. Please go ahead and make the change Brady requested and we will approve the PR for testing.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
#335 has been merged, closing this one as duplicate