aws-privateca-issuer icon indicating copy to clipboard operation
aws-privateca-issuer copied to clipboard

fix: HPA syntax, allow v2 API

Open fernandezcuesta opened this issue 1 year ago • 3 comments

HPA had apparently an additional field (checked v1 and v2 and none have namespace under scaleTargetRef. Support for HPA v2 added if supported by the target cluster.

fernandezcuesta avatar Sep 28 '23 13:09 fernandezcuesta

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot avatar Sep 28 '23 13:09 jetstack-bot

Good catch, I don't see namespace here either: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#crossversionobjectreference-v2-autoscaling. Please go ahead and make the change Brady requested and we will approve the PR for testing.

divyansh-gupta avatar Oct 06 '23 18:10 divyansh-gupta

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jetstack-bot avatar Oct 20 '23 20:10 jetstack-bot

#335 has been merged, closing this one as duplicate

bmsiegel avatar Aug 20 '24 15:08 bmsiegel