Edlib icon indicating copy to clipboard operation
Edlib copied to clipboard

Error on updated (and removed?) H5P library?

Open tmkarlsen opened this issue 3 years ago • 3 comments

Image Juxtaposition 1.5.0 The 1.5.0 version has been downloaded from https://github.com/otacke/h5p-image-juxtaposition and built from instructions. This has been done at least two times as new translations and features has been added to the source code, without any new version been set in the library.json file.

The first version of the 1.5.0 library has been tried removed, along with the content, in order to test the new package with the same version. Potentially leading to errors like this:

https://www.h5p-test.ndla.no/s/resources/3ef9c487-a445-45f8-b7d7-dcc88fb65d49 https://www.h5p-test.ndla.no/s/resources/fbfaeabc-92df-4ecd-8c8f-3b509e33937a

NDLA now wants to move forward with installing the latest 1.5.0 version of the package, as new resources created seem to work just fine. We should:

  1. Look into the errors in Edlib
  2. Consider suggesting a manipulation of the version they upload to e.g. 1.4.2 - as the current version they have installed is 1.4.1

tmkarlsen avatar Feb 24 '22 08:02 tmkarlsen

Clicking the trash button in CA admin doesn't actually remove the content associated with an H5P, seemingly against expectations. As a result, attempting to launch the H5P will cause H5PController::doShow to error when it accesses methods on H5PContent::$library, which at that point yields null.

Whether we choose to keep the current behaviour, or we ensure that hitting the button deletes all associated content, we should at least make sure the H5P isn't attempted launched.

emmachughes avatar Feb 24 '22 13:02 emmachughes

Similar issue for updated minor version on library for H5P image slider 1.1.3.

Previous libraries as possibly been manually deleted on test as shown in the list below: Skjermbilde 2022-08-03 kl  15 04 24

Vs. list from prod: Skjermbilde 2022-08-03 kl  15 04 36

EDIT: This could be related to H5P.ImageSlide being deleted. Looking into if this library can be found.

tmkarlsen avatar Aug 03 '22 12:08 tmkarlsen

Repo for the H5P.ImageSlide: https://github.com/falcon-git/h5p-image-slide

chrieinv avatar Mar 08 '23 13:03 chrieinv