Change name on H5P library

[tmkarlsen]

NDLA Virtual Tour 360 endres til NDLA Escape Room 360. Den får da nytt maskinavn som endres fra H5P.NDLAThreeImage til H5P.EscapeRoom. GitHub - NDLANO/h5p-escape-room: Escape Room puzzle content type for H5P

GitHub - NDLANO/h5p-editor-escape-room: Editor for interactive explorer content type

[tmkarlsen]

1. If the machine name changes, it will be seen as a new content type when installed. The drawback is that content on the old machine name cannot be easily updated to the new one.
2. This could be resolved by running a migration script.

[tmkarlsen]

Latest version of the current library installed:

• NDLA Virtual Tour (360) (0.4.103)

[chrieinv]

I've successfully installed the "old" content type, NDLA Virtual Tour (360), machine-name H5P.NDLAThreeImage, version 0.4.106. In version 0.5.0 onwards the content types has been renamed to NDLA Escape Room 360 with machine-name H5P.EscapeRoom. Attempting to install any version (05.0, 0.5.1, 0.5.2, 0.5.3 0.6.0) of this renamed content type in Edlib 3, from CA Admin, fails:

The file "dist/h5p-editor-ndla-escape-room.js" is missing from library: "H5PEditor.EscapeRoom-0.5"
The file "dist/h5p-editor-ndla-escape-room.css" is missing from library: "H5PEditor.EscapeRoom-0.5"

Additionally version 0.5.2 gives the error

Invalid language file zh_cn.json in library H5P.MultiChoice-1.16

The .h5p files was downloaded from https://github.com/NDLANO/h5p-escape-room/releases

[otacke]

@chrieinv It's well possible that the build pipeline that was created by a 3rd party broke, and I recommended not to use it multiple times, as it does not guarantee to give you official release versions of dependencies - it may as well pack untested development versions that can break things. The problem with MultiChoice looks like exactly that, for instance.

NDLA would need to decide on how they want to properly release their code or you should grab the sources from https://github.com/NDLANO/h5p-escape-room and https://github.com/NDLANO/h5p-editor-escape-room and https://github.com/NDLANO/h5p-ndla-three-sixty, build them, pack them and install them.

[chrieinv]

@otacke OK, thanks. I've build and packed them myself now, just missing some dependencies that I need to find and install

[otacke]

@chrieinv There shouldn't be any other uncommon hard dependencies. Some subcontents may not be obvious, but those should be soft dependencies and therefore optional.

[chrieinv]

@otacke It's finally installed. Only "surprise" dependency was that H5PEditor.EscapeRoom requires H5P.Crossword

[otacke]

@chrieinv I don't think the editor widget really needs it, because it doesn't render the subcontents (unlike e.g. Course Presentation). But I'd not rule out something weird going on ...