terra-framework icon indicating copy to clipboard operation
terra-framework copied to clipboard

Terra date input focus style

Open adoroshk opened this issue 10 months ago • 1 comments

Summary

This PR fixes focus style for terra-date-input which was overridden by form-input css (blue solid border appears instead of dashed border).

Testing

This change was tested using:

  • [x] WDIO
  • [x] Jest
  • [ ] Visual testing (please attach a screenshot or recording)
  • [ ] Other (please describe below)
  • [ ] No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • [ ] UX review
  • [ ] Accessibility review
  • [ ] Functional review

Additional Details

This PR resolves:

UXPLATFORM-10307

adoroshk avatar Apr 09 '24 19:04 adoroshk

Need @eawww help to figure out the correct styling for fusion theme focus if error, as current option on prod looks way different from just on focus:

Screenshot 2024-04-10 at 9 25 40 AM Screenshot 2024-04-10 at 9 25 45 AM

adoroshk avatar Apr 10 '24 13:04 adoroshk

Hi @adoroshk

For the default theme invalid state, since the visual border becomes wider (i think due to a box shadow) I'd recommend increasing the outline offset by 1px to ensure the required 1px gap between the border and focus indicator. Everything else looks good.

Standard focus indicator for fusion theme on this component's inputs appears to be border: 1px solid #dedfe0; box-shadow: 0 0 8px #a6d9f4;

eawww avatar Apr 10 '24 21:04 eawww

Hi @adoroshk

For the default theme invalid state, since the visual border becomes wider (i think due to a box shadow) I'd recommend increasing the outline offset by 1px to ensure the required 1px gap between the border and focus indicator. Everything else looks good.

Standard focus indicator for fusion theme on this component's inputs appears to be border: 1px solid #dedfe0; box-shadow: 0 0 8px #a6d9f4;

@eawww I have updated error and error + focus the styling, here is how it looks:

Default and Lowlight themes Error + Focus

Outline offset increased by 1px:

Screenshot 2024-04-12 at 4 08 04 PM Screenshot 2024-04-12 at 4 08 18 PM

Fusion focus styling

Changed to be border: 1px solid #dedfe0; box-shadow: 0 0 8px #a6d9f4;:

Screenshot 2024-04-12 at 4 10 13 PM Screenshot 2024-04-12 at 4 10 20 PM

Fusion Error + focus styling

Currently is is the same as a regular focus, should it be different?

Screenshot 2024-04-12 at 4 10 28 PM

adoroshk avatar Apr 12 '24 20:04 adoroshk