terra-framework icon indicating copy to clipboard operation
terra-framework copied to clipboard

[terra-tabs, terra-menu] allow icons in terra-menu, show icons when tabs collapsed

Open kschuste opened this issue 2 years ago • 2 comments

Summary

We currently have a use case where we want to warning icons in the tabs component. This included when the tabs are collapsed and the menu shown. We may have different types of warning icons across multiple tabs. Currently, when the tabs are collapsed, they are not shown in the tab or in the menu. This PR will allow for the icons to still display when the tabs are collapsed into 1 and to display the icons in the menu as well.

Closes #1569 Closes #1570

Deployment Link

https://terra-framework-deployed-pr-#.herokuapp.com/

Testing

Have tested these changes locally that they are passive.

Additional Details

Screen Shot 2022-09-12 at 2 58 05 PM

Screen Shot 2022-09-13 at 7 54 37 AM

Thank you for contributing to Terra. @cerner/terra

kschuste avatar Sep 13 '22 14:09 kschuste

Will take back to UX to review. Thanks @kschuste

neilpfeiffer avatar Sep 14 '22 14:09 neilpfeiffer

@neilpfeiffer any updates on this?

kschuste avatar Sep 27 '22 20:09 kschuste

Fails
:no_entry_sign: Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG is missing for:
  • terra-abstract-modal
  • terra-application-header-layout
  • terra-application-layout
  • terra-date-input
  • terra-date-picker
  • terra-date-time-picker
  • terra-dialog-modal
  • terra-notification-dialog
  • terra-slide-panel-manager
  • terra-time-input

Generated by :no_entry_sign: dangerJS against d576e5184546c51c74d311513e94124271af640e

terra-bot avatar Dec 06 '22 13:12 terra-bot

Fails
:no_entry_sign: Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG is missing for:
  • terra-abstract-modal
  • terra-application-header-layout
  • terra-application-layout
  • terra-date-input
  • terra-date-picker
  • terra-date-time-picker
  • terra-dialog-modal
  • terra-notification-dialog
  • terra-slide-panel-manager
  • terra-time-input

Generated by :no_entry_sign: dangerJS against 69ff377ef94ff681365f52ca3b7d0e40dc607868

JessieRandle avatar Dec 12 '22 15:12 JessieRandle