rust-ceramic icon indicating copy to clipboard operation
rust-ceramic copied to clipboard

Improved docs and logging for `migrations from-ipfs`

Open m0ar opened this issue 9 months ago • 2 comments

Heya :wave:

IPFS migration

I did a pass over the docs and logging to make it a bit easier to understand what's going on, after being confused more times than I care to admit with failing block imports (mostly related to incorrect paths in the input_file_list causing silent skips of the entire block set).

Took a swing at explaining some of the new validation options as well, LMK if something is factually incorrect!

RPC URLs config

Additionally, I got bitten by the fact that the --ethereum_rpc_urls flag/var seems to accept multiple endpoints, but in reality ignores everything after the first valid one. That's now made clear in the docs too. A potentially better fix would be to just accept a single one in config, but I chose to play defensively and not risk breaking startup for existing configs.

image image

m0ar avatar Mar 21 '25 10:03 m0ar

@smrz2001 what's the status of this PR? Can this be closed?

stbrody avatar May 21 '25 19:05 stbrody

@smrz2001 what's the status of this PR? Can this be closed?

Let me discuss this with @m0ar.

smrz2001 avatar May 21 '25 20:05 smrz2001

@stbrody @smrz2001 Hey guys, sorry for snoozing on this. I've applied the suggestions :)

m0ar avatar May 26 '25 13:05 m0ar