js-ceramic icon indicating copy to clipboard operation
js-ceramic copied to clipboard

feat: Add env var to disable Data Feed

Open stbrody opened this issue 1 year ago • 1 comments

stbrody avatar May 13 '24 19:05 stbrody

Could you please provide the rationale for why we want to be able to disable the data feed?

We are seeing an OOM crash in js-ceramic and are trying to eliminate variables. Data Feed is the newest big thing added to js-ceramic so if it was the cause it would explain why we never observed this OOM previously.

stbrody avatar May 13 '24 19:05 stbrody

Given that we seem to have discovered the source of the memory leak and it has nothing to do with DF, is this still worth adding or should we just close this PR without merging? @stephhuynh18

stbrody avatar May 15 '24 18:05 stbrody

Given that we seem to have discovered the source of the memory leak and it has nothing to do with DF, is this still worth adding or should we just close this PR without merging? @stephhuynh18

i think close makes sense

stephhuynh18 avatar May 15 '24 18:05 stephhuynh18