js-ceramic icon indicating copy to clipboard operation
js-ceramic copied to clipboard

feat: Use ajv-threads package to parallelize jsonSchema validation of ModelInstanceDocuments

Open stbrody opened this issue 1 year ago • 2 comments

stbrody avatar Feb 29 '24 20:02 stbrody

Why havent this been merged?

JulissaDantes avatar Mar 20 '24 15:03 JulissaDantes

Why havent this been merged?

We said that we want to see that this will improve performance before merging it. So far our testing has shown this PR having no impact on performance/throughput whatsoever, which is surprising, so we want to understand what's happening first.

Personally I'd be fine with merging and then iterating in develop, but I don't feel strongly and I believe @nathanielc prefers to wait.

stbrody avatar Mar 20 '24 15:03 stbrody