Chris Richardson

Introduced by https://github.com/eventuate-tram/eventuate-tram-core/commit/561efb54a5c3fce828b4fab3f1ccd2b13397e8ce#diff-4ddae9cb103afd937fecba907f653383bac59f746509b7bd5b8d409ee6db4337 but appear to be unused and duplicates of `eventuate-tram-spring-commands` I suspect the intent was to split commands into consumer and producer but this was never completed. Compare...

auto.offset.reset=latest should be the default for the Kafka Consumer

1

Currently can be set at the service-level with `eventuate.local.kafka.consumer.auto.offset.reset=latest`

is Publisher<List<Message>> useful/meaningful?

5

@ArtemSidorkin I'm wondering whether it's useful/meaningful since Publisher can contain multiple messages.

I don't the behavior that is being tested by the class needs to use the Database or Kafka. I believe what it's testing is that the event handler is executed...

https://github.com/eventuate-tram/eventuate-tram-core/blob/e2478023a4a03d00a0d00e271c2860fc59eeed12/eventuate-tram-reactive-consumer-jdbc/src/main/java/io/eventuate/tram/reactive/consumer/jdbc/ReactiveSqlTableBasedDuplicateMessageDetector.java#L11 See https://github.com/eventuate-tram/eventuate-tram-core/pull/145/#discussion_r650189786

@Import(TramInMemoryConfiguration) requires @Import(EventuateTransactionTemplateConfiguration)

3

A recent change has broken the Eventuate Tram API. An in-memory test should simply require `@Import(TramInMemoryConfiguration)`. However, the test must also `@Import(EventuateTransactionTemplateConfiguration)` This is because `TramInMemoryConfiguration` -> `@Import(TransactionalNoopDuplicateMessageDetectorConfiguration)`: ``` @Configuration...

Not sure why https://github.com/eventuate-tram/eventuate-tram-core/commit/bddf3e4b2760b9ce174188ccaa853eaa11a805a8 made this change. For example, ``` @Configuration public class TransactionalNoopDuplicateMessageDetectorConfiguration { @Bean public DuplicateMessageDetector duplicateMessageDetector(EventuateTransactionTemplate eventuateTransactionTemplate) { return new TransactionalNoopDuplicateMessageDetector(eventuateTransactionTemplate); } } ``` * TransactionalNoopDuplicateMessageDetectorConfiguration is...

``` public class DomainEventPublisherImpl implements DomainEventPublisher { ``` https://github.com/eventuate-tram/eventuate-tram-core/blob/cfea6b1c244db4249fad4a80b050200691b13150/eventuate-tram-spring-reactive-events-publisher/src/main/java/io/eventuate/tram/spring/events/publisher/ReactiveDomainEventPublisher.java#L18

e.g. * `Customer Service` subscribes to `Order Created` event * `Order Service` publishes `Order Approved` event * `SqlTableBasedDuplicateMessageDetector` in `Customer Service` records that `Order Approved` has been "processed" even though...

See https://github.com/microservices-patterns/ftgo-application/issues/111 from @futurexv2016 > Is this possible to use another message broker other than Kafka? I use K8S in GCP and it use google-cloud-PubSub ? Eventuate Tram supports multiple...