go-ceph icon indicating copy to clipboard operation
go-ceph copied to clipboard
verified publisher icon ceph

rgw/admin: support default-placement

Open thejoeejoee opened this issue 7 months ago • 1 comments

Checklist

  • [x] Added tests for features and functional changes
  • [ ] Public functions and types are documented
  • [x] Standard formatting is applied to Go code
  • [ ] Is this a new API? Added a new file that begins with //go:build ceph_preview
  • [ ] Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

thejoeejoee avatar Jun 12 '25 10:06 thejoeejoee

@thejoeejoee Is there a reason why you have kept this is in draft state?

anoopcs9 avatar Jun 16 '25 06:06 anoopcs9

@Mergifyio rebase

anoopcs9 avatar Jul 18 '25 06:07 anoopcs9

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Jul 18 '25 06:07 mergify[bot]

@thejoeejoee Are you planning to take this further?

anoopcs9 avatar Jul 18 '25 09:07 anoopcs9

@thejoeejoee We would like to consider the change but the commit message lacks the Signed-off-by: tag. Can you please update?

anoopcs9 avatar Aug 07 '25 09:08 anoopcs9

@Mergifyio rebase

anoopcs9 avatar Aug 07 '25 17:08 anoopcs9

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 07 '25 17:08 mergify[bot]

@thejoeejoee What do you think?

Would you mind including the additional change from https://github.com/ceph/go-ceph/pull/1133#pullrequestreview-3119966040?

anoopcs9 avatar Aug 24 '25 09:08 anoopcs9