go-ceph
go-ceph copied to clipboard
rados: implement rados_getaddrs
This PR implements binding for rados_getaddrs.
Includes a unit test.
Checklist
- [x] Added tests for features and functional changes
- [x] Public functions and types are documented
- [x] Standard formatting is applied to Go code
- [x] Is this a new API? Added a new file that begins with
//go:build ceph_preview - [x] Ran
make api-updateto record new APIs
@phlogistonjohn I've fixed the comment. @anoopcs9 so I should remove the preview build tag? In the docs it says all new APIs must have it.
There seems to be a newer version of protobuf(and protobuf-compiler) causing update issues with squid CI jobs. This is due to the fact that protobuf-compiler is only available with CRB repository which is not enabled by default with ceph container images. Let's see if we could get another rebuild of squid with the latest protobuf and protobuf-compiler in time.
There seems to be a newer version of protobuf(and protobuf-compiler) causing update issues with
squidCI jobs. This is due to the fact that protobuf-compiler is only available with CRB repository which is not enabled by default with ceph container images. Let's see if we could get another rebuild ofsquidwith the latest protobuf and protobuf-compiler in time.
It's not a required check so we have the option of trying to fix it and then asking @gman0 to rebase or just ignoring the failure for this PR. I will look into fixing it now... but if it proves tricky we can skip it.
squid workaround in #1038
@Mergifyio rebase
rebase