go-ceph icon indicating copy to clipboard operation
go-ceph copied to clipboard

rados: implement rados_getaddrs

Open gman0 opened this issue 1 year ago • 1 comments

This PR implements binding for rados_getaddrs.

Includes a unit test.

Checklist

  • [x] Added tests for features and functional changes
  • [x] Public functions and types are documented
  • [x] Standard formatting is applied to Go code
  • [x] Is this a new API? Added a new file that begins with //go:build ceph_preview
  • [x] Ran make api-update to record new APIs

gman0 avatar Oct 18 '24 16:10 gman0

@phlogistonjohn I've fixed the comment. @anoopcs9 so I should remove the preview build tag? In the docs it says all new APIs must have it.

gman0 avatar Oct 22 '24 10:10 gman0

There seems to be a newer version of protobuf(and protobuf-compiler) causing update issues with squid CI jobs. This is due to the fact that protobuf-compiler is only available with CRB repository which is not enabled by default with ceph container images. Let's see if we could get another rebuild of squid with the latest protobuf and protobuf-compiler in time.

anoopcs9 avatar Oct 22 '24 17:10 anoopcs9

There seems to be a newer version of protobuf(and protobuf-compiler) causing update issues with squid CI jobs. This is due to the fact that protobuf-compiler is only available with CRB repository which is not enabled by default with ceph container images. Let's see if we could get another rebuild of squid with the latest protobuf and protobuf-compiler in time.

It's not a required check so we have the option of trying to fix it and then asking @gman0 to rebase or just ignoring the failure for this PR. I will look into fixing it now... but if it proves tricky we can skip it.

phlogistonjohn avatar Oct 22 '24 18:10 phlogistonjohn

squid workaround in #1038

phlogistonjohn avatar Oct 22 '24 20:10 phlogistonjohn

@Mergifyio rebase

anoopcs9 avatar Oct 23 '24 11:10 anoopcs9

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Oct 23 '24 11:10 mergify[bot]