install-deps: script exit on "/ValueError" in centos_stream8

[nizamial09]

this is happening locally as well as in our ceph-dev runs too https://github.com/rhcs-dashboard/ceph-dev/runs/7850564011?check_suite_focus=true

The original error here is this

libsemanage.semanage_read_policydb: Could not open kernel policy /var/lib/selinux/targeted/active/policy.kern for reading. (No such file or directory).
FileNotFoundError: [Errno 2] No such file or directory

which can be solved by installing the selinux-policy-targeted

Signed-off-by: Nizamudeen A [email protected]

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

• Tracker (select at least one)
  • [ ] References tracker ticket
  • [ ] Very recent bug; references commit where it was introduced
  • [ ] New feature (ticket optional)
  • [ ] Doc update (no ticket needed)
  • [ ] Code cleanup (no ticket needed)
• Component impact
  • [ ] Affects Dashboard, opened tracker ticket
  • [ ] Affects Orchestrator, opened tracker ticket
  • [ ] No impact that needs to be tracked
• Documentation (select at least one)
  • [ ] Updates relevant documentation
  • [ ] No doc update is appropriate
• Tests (select at least one)
  • [ ] Includes unit test(s)
  • [ ] Includes integration test(s)
  • [ ] Includes bug reproducer
  • [ ] No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[nizamial09]

If you don't understand why something was put there, or you couldn't manage to reproduce the issue that led it to be there, that's reason enough not to remove it.

So you have 2 options:

• Keep it there and ensure the new issue is fixed.
• Understand why it ended up there, why it's no longer needed and then remove it.

I'm not advocating for not removing questionable code, but we should be careful when doing it.

Understood, and you are right! I acted too rashly here.

The original error here is this

libsemanage.semanage_read_policydb: Could not open kernel policy /var/lib/selinux/targeted/active/policy.kern for reading. (No such file or directory).
FileNotFoundError: [Errno 2] No such file or directory

which can be solved by installing the selinux-policy-targeted, so my question here would be, do I need to add this in the install-deps script or just in the container where this script is being run?

[epuertat]

If you don't understand why something was put there, or you couldn't manage to reproduce the issue that led it to be there, that's reason enough not to remove it. So you have 2 options:

• Keep it there and ensure the new issue is fixed.
• Understand why it ended up there, why it's no longer needed and then remove it.

I'm not advocating for not removing questionable code, but we should be careful when doing it.

Understood, and you are right! I acted too rashly here.

The original error here is this

libsemanage.semanage_read_policydb: Could not open kernel policy /var/lib/selinux/targeted/active/policy.kern for reading. (No such file or directory).
FileNotFoundError: [Errno 2] No such file or directory

which can be solved by installing the selinux-policy-targeted, so my question here would be, do I need to add this in the install-deps script or just in the container where this script is being run?

Yeah, maybe we need to fix that: https://dbalifeeasy.com/tag/libsemanage-semanage_read_policydb-error-while-reading-kernel-policy-from-etc-selinux-targeted-active-policy-kern-no-such-file-or-directory/

[epuertat]

jenkins test api

[nizamial09]

jenkins test api

[epuertat]

@djgalloway @ktdreyer hey guys, are you ok with this change?

Nizam is removing the grep -q option so future failures are easier to debug.

[epuertat]

jenkins test make check