ceph
Clippy Lints
Warning! Many breaking changes here from clippy suggestions about best practices.
Yeah all of these changes are clippy suggestions that values weren't consumed by a function so they should be passed by reference or that enum's passed by reference would be more efficient if they were copied. I don't know how true the copy efficiency is because i haven't benchmarked it.
Yeah I could try a rebase and clippy again to see what happens.
On Tue, Sep 3, 2024 at 7:23 AM Xuanwo @.***> wrote:
Hi, @cholcombe973 https://github.com/cholcombe973, would you be interested in working on this again?
— Reply to this email directly, view it on GitHub https://github.com/ceph/ceph-rust/pull/37#issuecomment-2326662187, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXKUE23AB4IUCB7HTSCEWLZUXA73AVCNFSM6AAAAABNSILQTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRWGY3DEMJYG4 . You are receiving this because you were mentioned.Message ID: @.***>
Yeah I could try a rebase and clippy again to see what happens.
Perfect, thank you so much! I'm so happy you're still here, in this community.