ceph-csi icon indicating copy to clipboard operation
ceph-csi copied to clipboard
verified publisher icon ceph

rbd & cephfs: modify fencing logic

Open Rakshith-R opened this issue 3 weeks ago • 6 comments

Describe what this PR does

This commit does the following:

  • auto fence duration will be 1 year
  • always remove client address metadata in ControllerUnpublish()
  • removes logic to unfence in ControllerPublish()
  • add logic to auto unfence in GetFenceClient()
    • if client itself is blocked and expiry is within auto fence duration of 1 yr
    • and after cool down period of 5 mins
    • client will auto un-fence itself.

Testing logs

  • After mounting pod:
bash-5.1$ rbd image-meta ls ocs-storagecluster-cephblockpool/csi-vol-7e184c3c-6cff-48e8-a51f-058cf85
40fd9
There are 6 metadata on this image:

Key                                                                                                                          Value                                                         
.rbd.csi.ceph.com/clientaddress/0001-0011-openshift-storage-0000000000000003-7e184c3c-6cff-48e8-a51f-058cf8540fd9/compute-0  100.64.0.5  
...

bash-5.1$ ceph fs subvolume metadata ls ocs-storagecluster-cephfilesystem csi-vol-5d0b6c0e-380c-4388-b5f8-75181989b519 csi
{
    ".cephfs.csi.ceph.com/clientaddress/0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519/compute-0": "100.64.0.7",
    ".cephfs.csi.ceph.com/userid/0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519/compute-0": "csi-cephfs-node-ceph-user-g1-cd643577-babc-42cd-9fe4-2b8028f6ad18",
    "csi.ceph.com/cluster/name": "ocs-storagecluster-cephcluster",
    "csi.storage.k8s.io/pv/name": "pvc-a4d94eeb-a664-4daf-888c-50c1c3e3833e",
    "csi.storage.k8s.io/pvc/name": "cephfs-pvc",
    "csi.storage.k8s.io/pvc/namespace": "openshift-storage"
}
  • after tainting the node
bash-5.1$ ceph osd blocklist ls
listed 0 entries
bash-5.1$ ceph osd blocklist ls
cidr:100.64.0.5:0/32 2026-12-04T16:39:40.177691+0000
listed 1 entries
bash-5.1$ rbd image-meta ls ocs-storagecluster-cephblockpool/csi-vol-7e184c3c-6cff-48e8-a51f-058cf8540fd9
There are 4 metadata on this image:

Key                               Value                                   
csi.ceph.com/cluster/name         ocs-storagecluster-cephcluster          
csi.storage.k8s.io/pv/name        pvc-ef585b38-2d67-4651-8223-7021246d3f3a
csi.storage.k8s.io/pvc/name       raw-block-rbd-pvc                       
csi.storage.k8s.io/pvc/namespace  openshift-storage    

bash-5.1$ ceph osd blocklist ls
10.131.0.27:0/4045147051 2025-12-12T07:45:40.759269+0000
...
10.131.0.27:6801/1650798790 2025-12-12T06:35:54.795175+0000
listed 21 entries

bash-5.1$ ceph osd blocklist ls 10.131.0.27:0/3058396927 2025-12-12T06:33:01.511355+0000 ... 10.131.0.27:0/423785367 2025-12-12T07:45:40.759269+0000 cidr:100.64.0.7:0/32 2026-12-11T20:57:21.075994+0000 listed 22 entries bash-5.1$ ceph fs subvolume metadata ls ocs-storagecluster-cephfilesystem csi-vol-5d0b6c0e-380c-4388-b5f8-75181989b519 csi { "csi.storage.k8s.io/pv/name": "pvc-a4d94eeb-a664-4daf-888c-50c1c3e3833e", "csi.storage.k8s.io/pvc/name": "cephfs-pvc", "csi.storage.k8s.io/pvc/namespace": "openshift-storage" }

  • ControllerUnpublish:
I1204 10:50:27.736913       1 utils.go:350] ID: 24 Req-ID: 0001-0011-openshift-storage-0000000000000003-7e184c3c-6cff-48e8-a51f-058cf8540fd9 GRPC call: /csi.v1.Controller/ControllerUnpublishVolume
I1204 10:50:27.736980       1 utils.go:351] ID: 24 Req-ID: 0001-0011-openshift-storage-0000000000000003-7e184c3c-6cff-48e8-a51f-058cf8540fd9 GRPC request: {"node_id":"compute-0","volume_id":"0001-0011-openshift-storage-0000000000000003-7e184c3c-6cff-48e8-a51f-058cf8540fd9"}
I1204 10:50:27.739439       1 reflector.go:358] "Starting reflector" type="*v1.Secret" resyncPeriod="10m0s" reflector="github.com/ceph/ceph-csi/internal/util/k8s/secrets.go:107"
I1204 10:50:27.739467       1 reflector.go:404] "Listing and watching" type="*v1.Secret" reflector="github.com/ceph/ceph-csi/internal/util/k8s/secrets.go:107"
I1204 10:50:27.806817       1 omap.go:89] ID: 24 Req-ID: 0001-0011-openshift-storage-0000000000000003-7e184c3c-6cff-48e8-a51f-058cf8540fd9 got omap values: (pool="ocs-storagecluster-cephblockpool", namespace="", name="csi.volume.7e184c3c-6cff-48e8-a51f-058cf8540fd9"): map[csi.imageid:5fba6153f8a7 csi.imagename:csi-vol-7e184c3c-6cff-48e8-a51f-058cf8540fd9 csi.volname:pvc-ef585b38-2d67-4651-8223-7021246d3f3a csi.volume.owner:openshift-storage]
I1204 10:50:27.876431       1 reflector.go:436] "Caches populated" type="*v1.Secret" reflector="github.com/ceph/ceph-csi/internal/util/k8s/secrets.go:107"
I1204 10:50:28.110260       1 controllerserver.go:1790] ID: 24 Req-ID: 0001-0011-openshift-storage-0000000000000003-7e184c3c-6cff-48e8-a51f-058cf8540fd9 successfully removed user ID mapping for nodeId compute-0
I1204 10:50:29.041667       1 utils.go:357] ID: 24 Req-ID: 0001-0011-openshift-storage-0000000000000003-7e184c3c-6cff-48e8-a51f-058cf8540fd9 GRPC response: {}

I1211 15:07:57.286803       1 utils.go:350] ID: 31 Req-ID: 0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519 GRPC call: /csi.v1.Controller/ControllerUnpublishVolume
I1211 15:07:57.286954       1 utils.go:351] ID: 31 Req-ID: 0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519 GRPC request: {"node_id":"compute-0","volume_id":"0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519"}
I1211 15:07:57.292323       1 reflector.go:358] "Starting reflector" type="*v1.Secret" resyncPeriod="10m0s" reflector="github.com/ceph/ceph-csi/internal/util/k8s/secrets.go:107"
I1211 15:07:57.292365       1 reflector.go:404] "Listing and watching" type="*v1.Secret" reflector="github.com/ceph/ceph-csi/internal/util/k8s/secrets.go:107"
I1211 15:07:57.428723       1 reflector.go:436] "Caches populated" type="*v1.Secret" reflector="github.com/ceph/ceph-csi/internal/util/k8s/secrets.go:107"
I1211 15:08:08.377999       1 omap.go:89] ID: 31 Req-ID: 0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519 got omap values: (pool="ocs-storagecluster-cephfilesystem-metadata", namespace="csi", name="csi.volume.5d0b6c0e-380c-4388-b5f8-75181989b519"): map[csi.imagename:csi-vol-5d0b6c0e-380c-4388-b5f8-75181989b519 csi.volname:pvc-a4d94eeb-a664-4daf-888c-50c1c3e3833e csi.volume.owner:openshift-storage]
I1211 15:08:09.015404       1 controllerserver.go:1281] ID: 31 Req-ID: 0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519 userID mapping metadata .cephfs.csi.ceph.com/userid/0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519/compute-0 unset for subvolume csi-vol-5d0b6c0e-380c-4388-b5f8-75181989b519
I1211 15:08:10.037632       1 utils.go:357] ID: 31 Req-ID: 0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519 GRPC response: {}
  • After removing taint and nodeplugin comes back on the node:
I1204 10:54:35.071053 1519008 utils.go:350] ID: 6 GRPC call: /fence.FenceController/GetFenceClients
I1204 10:54:35.071313 1519008 utils.go:351] ID: 6 GRPC request: {"parameters":{"clusterID":"openshift-storage"},"secrets":"***stripped***"}
I1204 10:54:35.125143 1519008 network_fence.go:230] ID: 6 auto-unfencing client with address "100.64.0.5/32"
I1204 10:54:36.190540 1519008 utils.go:357] ID: 6 GRPC response: {"clients":[{"addresses":[{"cidr":"100.64.0.5/32"}],"id":"ece6d53d-44cf-4362-9b1f-fe3da2d7966b"}]}
  • blocklist and image meta after mounting pod again
bash-5.1$ ceph osd blocklist ls
listed 0 entries
---

bash-5.1$ rbd image-meta ls ocs-storagecluster-cephblockpool/csi-vol-7e184c3c-6cff-48e8-a51f-058cf8540fd9
There are 6 metadata on this image:

Key                                                                                                                          Value                                                         
.rbd.csi.ceph.com/clientaddress/0001-0011-openshift-storage-0000000000000003-7e184c3c-6cff-48e8-a51f-058cf8540fd9/compute-0  100.64.0.5/32                                                 
.rbd.csi.ceph.com/userid/0001-0011-openshift-storage-0000000000000003-7e184c3c-6cff-48e8-a51f-058cf8540fd9/compute-0         csi-rbd-node-ceph-user-g1-ed824a5e-04c9-4e20-a9d8-29f0af9f5182
csi.ceph.com/cluster/name                                                                                                    ocs-storagecluster-cephcluster                                
csi.storage.k8s.io/pv/name                                                                                                   pvc-ef585b38-2d67-4651-8223-7021246d3f3a                      
csi.storage.k8s.io/pvc/name                                                                                                  raw-block-rbd-pvc                                             
csi.storage.k8s.io/pvc/namespace                                                                                             openshift-storage 

bash-5.1$ ceph fs subvolume metadata ls ocs-storagecluster-cephfilesystem csi-vol-5d0b6c0e-380c-4388-b5f8-75181989b519 csi
{
    ".cephfs.csi.ceph.com/clientaddress/0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519/compute-0": "100.64.0.7",
    ".cephfs.csi.ceph.com/userid/0001-0011-openshift-storage-0000000000000001-5d0b6c0e-380c-4388-b5f8-75181989b519/compute-0": "csi-cephfs-node-ceph-user-g1-cd643577-babc-42cd-9fe4-2b8028f6ad18",
    "csi.ceph.com/cluster/name": "ocs-storagecluster-cephcluster",
    "csi.storage.k8s.io/pv/name": "pvc-a4d94eeb-a664-4daf-888c-50c1c3e3833e",
    "csi.storage.k8s.io/pvc/name": "cephfs-pvc",
    "csi.storage.k8s.io/pvc/namespace": "openshift-storage"
}
  • cooldown period error
I1216 11:05:49.238891       1 utils.go:350] ID: 104 GRPC call: /fence.FenceController/GetFenceClients
I1216 11:05:49.238934       1 utils.go:351] ID: 104 GRPC request: {"parameters":{"clusterID":"openshift-storage"},"secrets":"***stripped***"}
E1216 11:05:49.240216       1 fencing.go:519] ID: 104 failed to auto unfence client: blocklist entry "100.64.0.6:0/32" is still in cool-down period for 2m57.000622843s
E1216 11:05:49.240255       1 utils.go:355] ID: 104 GRPC error: rpc error: code = Internal desc = failed to unfence client: blocklist entry "100.64.0.6:0/32" is still in cool-down period for 2m57.000622843s

Checklist:

  • [ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • [ ] Reviewed the developer guide on Submitting a Pull Request
  • [ ] Pending release notes updated with breaking and/or notable changes for the next major release.
  • [ ] Documentation has been updated, if necessary.
  • [ ] Unit tests have been added, if necessary.
  • [ ] Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated failure (please report the failure too!)

Rakshith-R avatar Dec 03 '25 09:12 Rakshith-R

Added testing logs in pr description. Please take a look.

Rakshith-R avatar Dec 04 '25 11:12 Rakshith-R

IPv6 and ceph's weird blocklist entry containing port ":0" in cidr range is handled now too. With complete support for cephfs fencing. (logs for cephfs fencing testing will be added to pr description) PTAL

Rakshith-R avatar Dec 11 '25 12:12 Rakshith-R

/test ci/centos/mini-e2e/k8s-1.34

Rakshith-R avatar Dec 15 '25 08:12 Rakshith-R

/test ci/centos/mini-e2e/k8s-1.34

Rakshith-R avatar Dec 15 '25 08:12 Rakshith-R

/test ci/centos/mini-e2e/k8s-1.34

Rakshith-R avatar Dec 15 '25 08:12 Rakshith-R

/test ci/centos/mini-e2e/k8s-1.34

Rakshith-R avatar Dec 16 '25 07:12 Rakshith-R

@Mergifyio rebase

iPraveenParihar avatar Dec 18 '25 12:12 iPraveenParihar

rebase

✅ Nothing to do for rebase action

mergify[bot] avatar Dec 18 '25 12:12 mergify[bot]

@Mergifyio queue

iPraveenParihar avatar Dec 18 '25 12:12 iPraveenParihar

queue

❌ The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify[bot] avatar Dec 18 '25 12:12 mergify[bot]

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 6daf07c818653f884c4f195f5390a47513292544

This pull request spent 1 hour 17 minutes 23 seconds in the queue, including 1 hour 16 minutes 57 seconds running CI. The checks were run on draft #5870.

Required conditions to merge
  • [ ] any of:
    • [ ] all of:
      • [ ] base~=^(release-.+)$
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.31
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.33
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.33
          • [X] status-success=ci/centos/upgrade-tests-cephfs
          • [X] status-success=ci/centos/upgrade-tests-rbd
      • [X] status-success=codespell
      • [X] status-success=go-test
      • [X] status-success=golangci-lint
      • [X] status-success=lint-extras
      • [X] status-success=mod-check
      • [X] status-success=multi-arch-build
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] base=release-v3.14
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.30
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.31
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.30
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.30
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [X] status-success=ci/centos/upgrade-tests-cephfs
          • [X] status-success=ci/centos/upgrade-tests-rbd
      • [X] status-success=codespell
      • [X] status-success=go-test
      • [X] status-success=golangci-lint
      • [X] status-success=lint-extras
      • [X] status-success=mod-check
      • [X] status-success=multi-arch-build
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.33
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.34
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.34
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.34
          • [X] status-success=ci/centos/upgrade-tests-cephfs
          • [X] status-success=ci/centos/upgrade-tests-rbd
      • [X] base=devel
      • [X] status-success=codespell
      • [X] status-success=go-test
      • [X] status-success=golangci-lint
      • [X] status-success=lint-extras
      • [X] status-success=mod-check
      • [X] status-success=multi-arch-build
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] base=ci/centos
      • [ ] status-success=ci/centos/jjb-validate
      • [ ] status-success=ci/centos/job-validation
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • [X] #5828
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • [X] #5828

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Dec 18 '25 12:12 mergify[bot]

@mergifyio rebase

Rakshith-R avatar Dec 19 '25 06:12 Rakshith-R

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Dec 19 '25 06:12 mergify[bot]

@mergifyio queue

Rakshith-R avatar Dec 19 '25 06:12 Rakshith-R

queue

❌ The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify[bot] avatar Dec 19 '25 06:12 mergify[bot]

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 4313ee64f02ab92715d3d3f913dd292e9c258be9

This pull request spent 1 hour 15 minutes 52 seconds in the queue, including 1 hour 15 minutes 40 seconds running CI. The checks were run on draft #5875.

Required conditions to merge
  • [ ] any of:
    • [ ] all of:
      • [ ] base~=^(release-.+)$
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.31
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.33
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.33
          • [X] status-success=ci/centos/upgrade-tests-cephfs
          • [X] status-success=ci/centos/upgrade-tests-rbd
      • [X] status-success=codespell
      • [X] status-success=go-test
      • [X] status-success=golangci-lint
      • [X] status-success=lint-extras
      • [X] status-success=mod-check
      • [X] status-success=multi-arch-build
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] base=release-v3.14
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.30
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.31
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.30
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.30
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [X] status-success=ci/centos/upgrade-tests-cephfs
          • [X] status-success=ci/centos/upgrade-tests-rbd
      • [X] status-success=codespell
      • [X] status-success=go-test
      • [X] status-success=golangci-lint
      • [X] status-success=lint-extras
      • [X] status-success=mod-check
      • [X] status-success=multi-arch-build
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.33
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.34
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.34
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.34
          • [X] status-success=ci/centos/upgrade-tests-cephfs
          • [X] status-success=ci/centos/upgrade-tests-rbd
      • [X] base=devel
      • [X] status-success=codespell
      • [X] status-success=go-test
      • [X] status-success=golangci-lint
      • [X] status-success=lint-extras
      • [X] status-success=mod-check
      • [X] status-success=multi-arch-build
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] base=ci/centos
      • [ ] status-success=ci/centos/jjb-validate
      • [ ] status-success=ci/centos/job-validation
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • [X] #5828
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • [X] #5828

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Dec 19 '25 06:12 mergify[bot]

@mergifyio requeue

nixpanic avatar Dec 19 '25 11:12 nixpanic

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify[bot] avatar Dec 19 '25 11:12 mergify[bot]

@mergifyio queue

nixpanic avatar Dec 19 '25 11:12 nixpanic

queue

❌ The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify[bot] avatar Dec 19 '25 11:12 mergify[bot]

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 4313ee64f02ab92715d3d3f913dd292e9c258be9

This pull request spent 50 seconds in the queue, including 34 seconds running CI. The checks were run on draft #5878.

Required conditions to merge
  • [ ] any of:
    • [ ] all of:
      • [ ] base~=^(release-.+)$
      • [ ] status-success=codespell
      • [ ] status-success=go-test
      • [ ] status-success=golangci-lint
      • [ ] status-success=lint-extras
      • [ ] status-success=mod-check
      • [ ] status-success=multi-arch-build
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.31
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.33
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.33
          • [ ] status-success=ci/centos/upgrade-tests-cephfs
          • [ ] status-success=ci/centos/upgrade-tests-rbd
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] base=release-v3.14
      • [ ] status-success=codespell
      • [ ] status-success=go-test
      • [ ] status-success=golangci-lint
      • [ ] status-success=lint-extras
      • [ ] status-success=mod-check
      • [ ] status-success=multi-arch-build
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.30
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.31
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.30
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.30
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/upgrade-tests-cephfs
          • [ ] status-success=ci/centos/upgrade-tests-rbd
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] status-success=codespell
      • [ ] status-success=go-test
      • [ ] status-success=golangci-lint
      • [ ] status-success=lint-extras
      • [ ] status-success=mod-check
      • [ ] status-success=multi-arch-build
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.33
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.34
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.34
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.34
          • [ ] status-success=ci/centos/upgrade-tests-cephfs
          • [ ] status-success=ci/centos/upgrade-tests-rbd
      • [X] base=devel
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] base=ci/centos
      • [ ] status-success=ci/centos/jjb-validate
      • [ ] status-success=ci/centos/job-validation
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • [X] #5828
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • [X] #5828

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Dec 19 '25 11:12 mergify[bot]

@mergifyio rebase

Rakshith-R avatar Dec 19 '25 13:12 Rakshith-R

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Dec 19 '25 13:12 mergify[bot]

@mergifyio queue

Rakshith-R avatar Dec 19 '25 13:12 Rakshith-R

queue

❌ The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify[bot] avatar Dec 19 '25 13:12 mergify[bot]

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at cbeff65c2771e8e6093235f2b70b076036031147

This pull request spent 54 seconds in the queue, including 40 seconds running CI. The checks were run on draft #5879.

Required conditions to merge
  • [ ] any of:
    • [ ] all of:
      • [ ] base~=^(release-.+)$
      • [ ] status-success=codespell
      • [ ] status-success=go-test
      • [ ] status-success=golangci-lint
      • [ ] status-success=lint-extras
      • [ ] status-success=mod-check
      • [ ] status-success=multi-arch-build
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.31
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.33
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.33
          • [ ] status-success=ci/centos/upgrade-tests-cephfs
          • [ ] status-success=ci/centos/upgrade-tests-rbd
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] base=release-v3.14
      • [ ] status-success=codespell
      • [ ] status-success=go-test
      • [ ] status-success=golangci-lint
      • [ ] status-success=lint-extras
      • [ ] status-success=mod-check
      • [ ] status-success=multi-arch-build
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.30
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.31
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.30
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.30
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.31
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/upgrade-tests-cephfs
          • [ ] status-success=ci/centos/upgrade-tests-rbd
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] status-success=codespell
      • [ ] status-success=go-test
      • [ ] status-success=golangci-lint
      • [ ] status-success=lint-extras
      • [ ] status-success=mod-check
      • [ ] status-success=multi-arch-build
      • [ ] any of:
        • label=ci/skip/e2e
          • [ ] #5828
        • [ ] all of:
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.32
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.33
          • [ ] status-success=ci/centos/k8s-e2e-external-storage/1.34
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e-helm/k8s-1.34
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.32
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.33
          • [ ] status-success=ci/centos/mini-e2e/k8s-1.34
          • [ ] status-success=ci/centos/upgrade-tests-cephfs
          • [ ] status-success=ci/centos/upgrade-tests-rbd
      • [X] base=devel
      • [X] status-success=uncommitted-code-check
    • [ ] all of:
      • [ ] base=ci/centos
      • [ ] status-success=ci/centos/jjb-validate
      • [ ] status-success=ci/centos/job-validation
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • [X] #5828
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • [X] #5828

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Dec 19 '25 13:12 mergify[bot]

@mergifyio requeue

There have been a few infrastructure issues in the CentOS CI. Hopefully these have been addressed now.

nixpanic avatar Dec 19 '25 14:12 nixpanic

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify[bot] avatar Dec 19 '25 14:12 mergify[bot]

@mergifyio queue

nixpanic avatar Dec 19 '25 14:12 nixpanic

queue

❌ The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify[bot] avatar Dec 19 '25 14:12 mergify[bot]