Enable object-map,exclusive-lock or use the storageClass imageFeatures for "-temp" cloned RBD volumes

[dimm0]

Describe the feature you'd like to have

In https://github.com/ceph/ceph-csi/blob/00c7fb3136b36b77880475ed371d3e0e76076b05/internal/rbd/clone.go#L115 the features for -temp volumes are hard-coded to layering,flatten, making it impossible to do rbd du in that cluster. Would it be possible to take the list of features from CSI config the same way it'sfor regular images? Or also enable object-map,exclusive-lock for these?

What is the value to the end user? (why is it a priority?)

Be able to see rbd du for all images quickly

How would the end user gain value from having this feature? Quick rbd du

[Madhu-1]

Describe the feature you'd like to have

In

https://github.com/ceph/ceph-csi/blob/00c7fb3136b36b77880475ed371d3e0e76076b05/internal/rbd/clone.go#L115

the features for -temp volumes are hard-coded to layering,flatten, making it impossible to do rbd du in that cluster. Would it be possible to take the list of features from CSI config the same way it'sfor regular images? Or also enable object-map,exclusive-lock for these?

What is the value to the end user? (why is it a priority?)

Be able to see rbd du for all images quickly

How would the end user gain value from having this feature? Quick rbd du

As these are the default in RBD, this can also be changed to include those. @nixpanic @Rakshith-R any thoughts on this?

[nixpanic]

My preference would be to add the options for the cloning process, but ideally not an other configuration parameter if we can avoid it.

Has it been confirmed that with those options rbd du is not blocked while cloning images?

[dimm0]

It still seems slow but faster than without... I don't have enough knowledge about the snapshots to explain it.

[Rakshith-R]

I think we should

• In pvc-pvc clone case, use same imageFeatures for -temp image as the final one
• In volumensnapshot case, inherit it from the parent image.

[iPraveenParihar]

/assign

[github-actions[bot]]

Thanks for taking this issue! Let us know if you have any questions!

[Rakshith-R]

I think we should

• In pvc-pvc clone case, use same imageFeatures for -temp image as the final one
• In volumensnapshot case, inherit it from the parent image.

• volumeGroupSnapshot

We also need to ensure layers and deep-flatten are definitely present on temp and snapshot backing image since they are needed for proper flattening to occur.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.