ceph-csi icon indicating copy to clipboard operation
ceph-csi copied to clipboard

[Draft] Add Modfify volume rpc support

Open Nikhil-Ladha opened this issue 1 year ago • 2 comments

Add ControllerModifyVolume RPC support for ceph-csi.

Describe what this PR does

Provide some context for the reviewer

Is there anything that requires special attention

Do you have any questions?

Is the change backward compatible?

Are there concerns around backward compatibility?

Provide any external context for the change, if any.

For example:

  • Kubernetes links that explain why the change is required
  • CSI spec related changes/catch-up that necessitates this patch
  • golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line will help to auto close the issue once the PR is merged.

Fixes: #issue_number

Future concerns

List items that are not part of the PR and do not impact it's functionality, but are work items that can be taken up subsequently.

Checklist:

  • [ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • [ ] Reviewed the developer guide on Submitting a Pull Request
  • [ ] Pending release notes updated with breaking and/or notable changes for the next major release.
  • [ ] Documentation has been updated, if necessary.
  • [ ] Unit tests have been added, if necessary.
  • [ ] Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated failure (please report the failure too!)

Nikhil-Ladha avatar Oct 24 '24 07:10 Nikhil-Ladha

Just a POC PR for cephfs component, if the approach looks right then will make the changes for rbd and nfs as well. cc @Madhu-1 @nixpanic

Nikhil-Ladha avatar Oct 24 '24 07:10 Nikhil-Ladha

@Nikhil-Ladha it would be good to update what you are trying to achieve in the PR description and commit and what are the parameters we are planning to have modified.

Please update or open an issue to cover

  • Documentation (how to use this feature)
  • Required Yaml changes
  • E2E changes to ensure the feature works
  • what are immutable parameters in the drivers.

Madhu-1 avatar Oct 24 '24 07:10 Madhu-1

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 08 '24 21:12 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 08 '25 21:01 github-actions[bot]

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

github-actions[bot] avatar Jan 23 '25 21:01 github-actions[bot]