ceph-csi icon indicating copy to clipboard operation
ceph-csi copied to clipboard

deploy: Add skipForceFlatten for daemonset nodeplugin

Open muxuelanKK opened this issue 1 year ago • 1 comments

Describe what this PR does

Provide some context for the reviewer

Is there anything that requires special attention

Do you have any questions?

Is the change backward compatible?

Are there concerns around backward compatibility?

Provide any external context for the change, if any.

For example:

  • Kubernetes links that explain why the change is required
  • CSI spec related changes/catch-up that necessitates this patch
  • golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line will help to auto close the issue once the PR is merged.

Fixes: #issue_number

Future concerns

List items that are not part of the PR and do not impact it's functionality, but are work items that can be taken up subsequently.

Checklist:

  • [ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • [ ] Reviewed the developer guide on Submitting a Pull Request
  • [ ] Pending release notes updated with breaking and/or notable changes for the next major release.
  • [ ] Documentation has been updated, if necessary.
  • [ ] Unit tests have been added, if necessary.
  • [ ] Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated failure (please report the failure too!)

muxuelanKK avatar Sep 25 '24 14:09 muxuelanKK

Hi @muxuelanKK, thanks for the PR!

Could you update the title of your commit to something like

deploy: Add skipForceFlatten for daemonset nodeplugin

A keyword like deploy, or rbd is required so that it is easier for reviewers to understand what the PR/commit is about. Once changing in your local branch, make sure to force-push the single commit to your GitHub repo/branch.

Currently the PR description does not contain anything useful. You can either use the template that is present now, or describe the need for the change in free form (it is good practice to include a description in the commit too).

nixpanic avatar Sep 25 '24 14:09 nixpanic

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 26 '24 21:10 github-actions[bot]

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

github-actions[bot] avatar Nov 10 '24 21:11 github-actions[bot]