ceph-csi icon indicating copy to clipboard operation
ceph-csi copied to clipboard

cleanup: remove unneeded `updateSnapshotDetails()` function

Open nixpanic opened this issue 1 year ago • 14 comments

updateSnapshotDetails() just calls getImageInfo() on an rbdVolume created from the rbdSnapshot. getImageInfo() is a function of the base rbdImage struct, so there really is no need for this indirection.

nixpanic avatar Sep 16 '24 16:09 nixpanic

@mergifyio queue

nixpanic avatar Sep 17 '24 07:09 nixpanic

/test ci/centos/k8s-e2e-external-storage/1.29

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/k8s-e2e-external-storage/1.31

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/mini-e2e-helm/k8s-1.29

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/k8s-e2e-external-storage/1.30

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/mini-e2e/k8s-1.29

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/mini-e2e-helm/k8s-1.31

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/mini-e2e-helm/k8s-1.30

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/mini-e2e/k8s-1.31

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

/test ci/centos/mini-e2e/k8s-1.30

ceph-csi-bot avatar Sep 17 '24 08:09 ceph-csi-bot

Something isn't right here... Maybe the ImageID of the snapshot/parent should not get updated?

nixpanic avatar Sep 17 '24 08:09 nixpanic

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 17 '24 21:10 github-actions[bot]

/test ci/centos/mini-e2e/k8s-1.30

nixpanic avatar Nov 22 '24 17:11 nixpanic

queue

🟠 Waiting for conditions to match

  • [ ] -closed [📌 queue requirement]
  • [ ] -draft [📌 queue requirement]
  • [ ] any of: [🔀 queue conditions]
    • [ ] all of: [📌 queue conditions of queue default]
      • [ ] #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • [X] #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • [X] -conflict [📌 queue requirement]
  • [X] any of: [📌 queue -> configuration change requirements]
    • [X] -mergify-configuration-changed
    • [ ] check-success = Configuration changed

mergify[bot] avatar Dec 17 '24 15:12 mergify[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 16 '25 21:01 github-actions[bot]

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

github-actions[bot] avatar Jan 31 '25 21:01 github-actions[bot]