ceph-csi Can we share VolumeLocks for NodeServer/ControllerServer?

          lets discuss on this one and we need to see can what will happen when we try to do nodeserver operations like (expand/umount) etc when the fstrim is going on can it leads to corruption etc. based on that we can have central/shared locking. Is it allowed to expand or remove the image when the ControllerReclaimOperation is going on etc.

Originally posted by @Madhu-1 in https://github.com/ceph/ceph-csi/pull/4641#discussion_r1616758500

May 29 '24 08:05 iPraveenParihar

lets discuss on this one and we need to see can what will happen when we try to do nodeserver operations like (expand/umount) etc when the fstrim is going on can it leads to corruption etc. based on that we can have central/shared locking.

I do not think this can cause corruption. If so, it is a bug in the filesystem.

Is it allowed to expand or remove the image when the ControllerReclaimOperation is going on etc.

expanding should be allowed, but maybe RBD prevents running both operations at the same time?
while ControllerReclaim is running, the image is open, so deleting it may not be possible (and the CO should retry with backoff)

May 30 '24 16:05 nixpanic

lets discuss on this one and we need to see can what will happen when we try to do nodeserver operations like (expand/umount) etc when the fstrim is going on can it leads to corruption etc. based on that we can have central/shared locking.

I do not think this can cause corruption. If so, it is a bug in the filesystem.

Is it allowed to expand or remove the image when the ControllerReclaimOperation is going on etc.

expanding should be allowed, but maybe RBD prevents running both operations at the same time?

while ControllerReclaim is running, the image is open, so deleting it may not be possible (and the CO should retry with backoff)

@nixpanic yes once we test these things and decide letter on!

May 31 '24 11:05 Madhu-1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

Jun 30 '24 21:06 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

Jul 31 '24 21:07 github-actions[bot]

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

Aug 08 '24 21:08 github-actions[bot]

decided to share locks https://github.com/ceph/ceph-csi/pull/4641. closing this.

Aug 09 '24 05:08 iPraveenParihar