ceph-csi icon indicating copy to clipboard operation
ceph-csi copied to clipboard

ci: add gosec for golang security scanning

Open Madhu-1 opened this issue 1 year ago • 6 comments

Adding gosec security scanning as a CI job to run on each PR to ensure we are good with security problems.

More details at https://github.com/securego/gosec

@nixpanic @Rakshith-R @yati1998 @iPraveenParihar Do you guys prefer to run it on each PR or as a cronjob?

Note:- Based on above response need to modify mergify rules

Madhu-1 avatar Mar 01 '24 09:03 Madhu-1

Marking as WIP to analyse the CI issues

Madhu-1 avatar Mar 01 '24 09:03 Madhu-1

This is integrated in golangci-lint, maybe make sure it is enabled there?

https://golangci-lint.run/usage/linters/#gosec

nixpanic avatar Mar 01 '24 12:03 nixpanic

This is integrated in golangci-lint, maybe make sure it is enabled there?

https://golangci-lint.run/usage/linters/#gosec

Yes i missed that, let me check on that 👍🏻

Madhu-1 avatar Mar 01 '24 12:03 Madhu-1

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 31 '24 21:03 github-actions[bot]

@Madhu-1 did #4539 replace this?

nixpanic avatar Apr 11 '24 07:04 nixpanic

@Madhu-1 did #4539 replace this?

Not yet, will give a try and see if that's enough

Madhu-1 avatar Apr 11 '24 07:04 Madhu-1

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 11 '25 21:02 github-actions[bot]

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

github-actions[bot] avatar Feb 26 '25 21:02 github-actions[bot]