ceph-csi
ceph-csi copied to clipboard
ci: make minikube.sh work on macOS M1 with the qemu2 driver
Describe what this PR does
This PR makes scripts/minikube.sh work on macOS M1 with the qemu2 driver.
Some modifications have been made to handle the compatibility of bash scripts. For example, sed -i
without a value only works for GNU sed, but not for macOS's sed. The RESOLV_CONF
variable has been made configurable because it needs to be overridden as /etc/resolv.conf when using the qemu2 driver. In addition, minikube also supports adding extra disks for the qemu2 driver.
Related issues
No.
Future concerns
List items that are not part of the PR and do not impact it's functionality, but are work items that can be taken up subsequently.
Checklist:
- [x] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
- [x] Reviewed the developer guide on Submitting a Pull Request
- [ ] Pending release notes updated with breaking and/or notable changes for the next major release.
- [ ] Documentation has been updated, if necessary.
- [ ] Unit tests have been added, if necessary.
- [ ] Integration tests have been added, if necessary.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR:
-
/retest ci/centos/<job-name>
: retest the<job-name>
after unrelated failure (please report the failure too!)