ceph-csi icon indicating copy to clipboard operation
ceph-csi copied to clipboard

rbd: include trashed parent images while calculating the clone depth

Open nixpanic opened this issue 2 years ago • 55 comments

The getCloneDepth() function did not account for images that are in the trash. A trashed image can only be opened by the image-id, and not by name anymore.

Closes: #4013 Depends-on: #4064 #4273


Show available bot commands

These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated failure (please report the failure too!)

nixpanic avatar Aug 02 '23 10:08 nixpanic

/test ci/centos/mini-e2e/k8s-1.27

nixpanic avatar Aug 04 '23 07:08 nixpanic

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

mergify[bot] avatar Aug 08 '23 09:08 mergify[bot]

/test ci/centos/mini-e2e/k8s-1.27

nixpanic avatar Aug 22 '23 15:08 nixpanic

/test ci/centos/mini-e2e/k8s-1.27

nixpanic avatar Aug 22 '23 15:08 nixpanic

Manual stress testing with the scripts from rook/rook#12312 passes.

Need to fix the golangci-lint issues and have the go-ceph rebase merged before this is completely ready.

nixpanic avatar Aug 22 '23 15:08 nixpanic

@mergifyio rebase

nixpanic avatar Aug 30 '23 09:08 nixpanic

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Aug 30 '23 09:08 mergify[bot]

@mergifyio refresh

Rakshith-R avatar Sep 04 '23 05:09 Rakshith-R

refresh

✅ Pull request refreshed

mergify[bot] avatar Sep 04 '23 05:09 mergify[bot]

@mergifyio queue

Rakshith-R avatar Sep 04 '23 05:09 Rakshith-R

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment @mergifyio refresh on the pull request.

mergify[bot] avatar Sep 04 '23 05:09 mergify[bot]

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/k8s-e2e-external-storage/1.26

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/mini-e2e-helm/k8s-1.26

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/mini-e2e/k8s-1.26

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/mini-e2e/k8s-1.28

ceph-csi-bot avatar Sep 04 '23 05:09 ceph-csi-bot

/test ci/centos/upgrade-tests-rbd

Madhu-1 avatar Sep 04 '23 05:09 Madhu-1

/test ci/centos/mini-e2e-helm/k8s-1.28

Madhu-1 avatar Sep 04 '23 05:09 Madhu-1

/test ci/centos/mini-e2e/k8s-1.26

Madhu-1 avatar Sep 04 '23 05:09 Madhu-1

/test ci/centos/mini-e2e/k8s-1.27

Madhu-1 avatar Sep 04 '23 05:09 Madhu-1

It seems that there was some issue with snapshots. not sure why e2e passed earlier?!

nixpanic avatar Sep 04 '23 07:09 nixpanic

/test ci/centos/mini-e2e-helm/k8s-1.28

nixpanic avatar Sep 04 '23 07:09 nixpanic

e2e without the last go fmt fix is available at https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/mini-e2e-helm_k8s-1.28/detail/mini-e2e-helm_k8s-1.28/78/pipeline . This PR can be reviewed once that passed.

nixpanic avatar Sep 04 '23 07:09 nixpanic

/test ci/centos/mini-e2e-helm/k8s-1.28

nixpanic avatar Sep 04 '23 09:09 nixpanic