rbd: complete migration of volrep to csi-addons

[Rakshith-R]

TODO's:

• [ ] move logic to internal/csi-addons/rbd
• [ ] remove replication service from controller server
• [ ] add minimal unit tests like internal/csi-addons/rbd/reclaimspace_test.go
• [ ] https://github.com/ceph/ceph-csi/pull/3349

Originally posted by @nixpanic in https://github.com/ceph/ceph-csi/issues/3305#issuecomment-1216245713

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[yati1998]

@Rakshith-R I guess all the task here is done already. Can you confirm and close the issue, if done?

[Rakshith-R]

@Rakshith-R I guess all the task here is done already. Can you confirm and close the issue, if done?

No, 3 out of 4 TODOs are still not done.

@riya-singhal31 do you wanna take up this issue ?

[yati1998]

@Rakshith-R I guess all the task here is done already. Can you confirm and close the issue, if done?

No, 3 out of 4 TODOs are still not done. cool @riya-singhal31 do you wanna take up this issue ? yeah would be a good one

[riya-singhal31]

Closes with - https://github.com/ceph/ceph-csi/pull/3608

[Rakshith-R]

Closes with - #3608

you mean updates,

Make sure to address this comment too. three more tasks are remaining including the above one.

[riya-singhal31]

add minimal unit tests like internal/csi-addons/rbd/reclaimspace_test.go There is already a test file for replication.go, moved it to csi-addons. Do we need to add some more tests to it? cc @Rakshith-R

[Rakshith-R]

add minimal unit tests like internal/csi-addons/rbd/reclaimspace_test.go

There is already a test file for replication.go, moved it to csi-addons. Do we need to add some more tests to it? cc @Rakshith-R

They need to be added after completion of task 3 remove replication service from controller server refer https://github.com/ceph/ceph-csi/blob/devel/internal/csi-addons/rbd/reclaimspace_test.go.

[Madhu-1]

@riya-singhal31 any updates here?

[riya-singhal31]

@riya-singhal31 any updates here?

Yes, sending an updated PR.

[riya-singhal31]

https://github.com/ceph/ceph-csi/pull/3884 - addresses all the rest sub-items.

[riya-singhal31]

remove replication service from controller server

@Rakshith-R can you please elaborate on it. My understanding is that we want to remove the replication import from the files in internal/rbd, or something else is also needed here?

Have done this here, #3884

[Rakshith-R]

remove replication service from controller server

@Rakshith-R can you please elaborate on it. My understanding is that we want to remove the replication import from the files in internal/rbd, or something else is also needed here?

Have done this here, #3884

replication server still needs to be removed from rbd driver completely. https://github.com/ceph/ceph-csi/blob/devel/internal/rbd/driver/driver.go#L69

[riya-singhal31]

remove replication service from controller server

@Rakshith-R can you please elaborate on it. My understanding is that we want to remove the replication import from the files in internal/rbd, or something else is also needed here? Have done this here, #3884

replication server still needs to be removed from rbd driver completely. https://github.com/ceph/ceph-csi/blob/devel/internal/rbd/driver/driver.go#L69

Okay, thanks Rakshith.