rebase: use v0.17.0 of go-ceph library

[humblec]

new version of go ceph is available and this commit make use of the same. Ref # https://github.com/ceph/go-ceph/releases/tag/v0.17.0

Signed-off-by: Humble Chirammal [email protected]

[Madhu-1]

@humblec CI is failing can you please check

[humblec]

The new APIs are causing the failure.. the go-ceph part of these APIs are "preview mode" ,

  internal/cephfs/core/metadata.go:86:12: fsa.RemoveMetadata undefined (type *"github.com/ceph/go-ceph/cephfs/admin".FSAdmin has no field or method RemoveMetadata) (typecheck)
	err = fsa.RemoveMetadata(s.FsName, s.SubvolumeGroup, s.VolID, key)
	          ^
internal/cephfs/core/snapshot_metadata.go:64:12: fsa.SetSnapshotMetadata undefined (type *"github.com/ceph/go-ceph/cephfs/admin".FSAdmin has no field or method SetSnapshotMetadata) (typecheck)
	err = fsa.SetSnapshotMetadata(s.FsName, s.SubvolumeGroup, s.VolID, s.SnapshotID, key, value)
	          ^
internal/cephfs/core/snapshot_metadata.go:83:12: fsa.RemoveSnapshotMetadata undefined (type *"github.com/ceph/go-ceph/cephfs/admin".FSAdmin has no field or method RemoveSnapshotMetadata) (typecheck)
	err = fsa.RemoveSnapshotMetadata(s.FsName, s.SubvolumeGroup, s.VolID, s.SnapshotID, key)

Ceph build's ceph_preview tag is enabled for our builds already, may be we need a different tag ceph_pre_{pacific,quincy}, ceph_main ?

Cc @nixpanic @pkalever

[nixpanic]

Looks like the CephFS metadata functions are only valid for pre-Quincy versions? Not sure if Quincy requires other functions, or how it is done there. Maybe @pkalever knows.

[pkalever]

I think the reason we added those APIs as the preview was that the intended Ceph PRs introducing those metadata commands were still in master and not released in any Ceph release yet. Need to check if they were available in the latest release of Ceph and should move them to stable API sections in go-ceph.

Looks like the CephFS metadata functions are only valid for pre-Quincy versions? Not sure if Quincy requires other functions, or how it is done there. Maybe @pkalever knows.

Quincy and pre-quincy have the same commands and APIs, the original Quincy PRs are backported to the pacific and octopus.

[humblec]

As in https://github.com/ceph/ceph-csi/pull/3308#issuecomment-1217773138 , I think one of the tags below should help . ceph_pre_{qunicy/pacific} or ceph_main

[pkalever]

I think the reason we added those APIs as the preview was that the intended Ceph PRs introducing those metadata commands were still in master and not released in any Ceph release yet. Need to check if they were available in the latest release of Ceph and should move them to stable API sections in go-ceph.

Looks like these metadata commands are targeted for Ceph - v18.0.0, which is not out yet!, we still need to wait on this!

[humblec]

@nixpanic @pkalever as anticipated ceph_pre_quincy helps here. ptal .. thanks.

[mergify[bot]]

rebase

☑️ Nothing to do

• [X] -closed [:pushpin: rebase requirement]
• [ ] any of:
  • [ ] #commits-behind>0 [:pushpin: rebase requirement]
  • [ ] -linear-history [:pushpin: rebase requirement]

[humblec]

/retest ci/centos/k8s-e2e-external-storage/1.22

[humblec]

/retest ci/centos/upgrade-tests-cephfs

[humblec]

/retest ci/centos/mini-e2e/k8s-1.24

[humblec]

/retest ci/centos/mini-e2e/k8s-1.24

[humblec]

/retest ci/centos/mini-e2e-helm/k8s-1.22

[Rakshith-R]

@mergifyio rebase

[mergify[bot]]

rebase

✅ Branch has been successfully rebased