ceph-csi icon indicating copy to clipboard operation
ceph-csi copied to clipboard

implement VOLUME_CONDITION capability

Open pkalever opened this issue 3 years ago • 16 comments

Describe what this PR does

Node Volume Health checks if a volume is still mounted and usable. To check whether a volume is usable, the CSI driver shall check if filesystem is corrupted, whether there are bad blocks, etc. in this RPC.

// VolumeCondition represents the current condition of a volume.      
                                                                      
message VolumeCondition {                                             
  option (alpha_message) = true;                                      
                                                                      
  // Normal volumes are available for use and operating optimally.    
  // An abnormal volume does not meet these criteria.                 
  // This field is REQUIRED.                                          
  bool abnormal = 1;                                                  
                                                                      
  // The message describing the condition of the volume.              
  // This field is REQUIRED.                                          
  string message = 2;                                                 
}                                                                     

Signed-off-by: Prasanna Kumar Kalever <[email protected]>

Related issues

Fixes: #2794

Logs

With Feature Gates enabled: csi-rbdplugin.log metrics.log With Feature Gates disabled: csi-rbdplugin_without_fg.log metrics_without_fg.log


Show available bot commands

These commands are normally not required, but in case of issues, leave any of the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test progress or results

pkalever avatar Jan 31 '22 10:01 pkalever

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 06 '22 21:03 github-actions[bot]

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

mergify[bot] avatar Jun 03 '22 12:06 mergify[bot]

@Mergifyio rebase

pkalever avatar Jun 14 '22 05:06 pkalever

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Jun 14 '22 05:06 mergify[bot]

@Madhu-1 please find the logs requested With Feature Gates enabled: csi-rbdplugin.log metrics.log With Feature Gates disabled: metrics_without_fg.log csi-rbdplugin_without_fg.log

pkalever avatar Jun 20 '22 12:06 pkalever

@Mergifyio rebase

pkalever avatar Jun 21 '22 10:06 pkalever

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Jun 21 '22 10:06 mergify[bot]

@Mergifyio rebase

pkalever avatar Jun 24 '22 05:06 pkalever

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Jun 24 '22 05:06 mergify[bot]

@Mergifyio rebase

pkalever avatar Jun 29 '22 12:06 pkalever

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Jun 29 '22 12:06 mergify[bot]

/retest ci/centos/k8s-e2e-external-storage/1.23

pkalever avatar Jun 29 '22 15:06 pkalever

/retest all

pkalever avatar Jun 29 '22 16:06 pkalever

@Mergifyio rebase

pkalever avatar Jun 30 '22 03:06 pkalever

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Jun 30 '22 03:06 mergify[bot]

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

mergify[bot] avatar Jul 21 '22 07:07 mergify[bot]

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

mergify[bot] avatar Mar 22 '23 13:03 mergify[bot]

Hello there! There hasn't been any activity on this PR for quite some time, so I have removed the "keepalive" label. To avoid it being closed as stale shortly, please revisit and give it some attention. Thank you!

Madhu-1 avatar Apr 28 '23 05:04 Madhu-1

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 28 '23 21:05 github-actions[bot]

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

github-actions[bot] avatar Jun 11 '23 21:06 github-actions[bot]