ceph-csi icon indicating copy to clipboard operation
ceph-csi copied to clipboard

static manifests from helm chart

Open kfox1111 opened this issue 6 years ago • 10 comments

Currently we have two different implementations of the driver plumbing. The helm chart and the static manifests. They can and do get out of sync. We could generate the static manifests as part of the release process by running 'helm template' on the chart. Then there would only be one set of templates to update for both use cases.

kfox1111 avatar Jan 23 '19 20:01 kfox1111

+1

mcronce avatar Jan 25 '19 04:01 mcronce

Question. should we just have it upload the generated objects somewhere on release, like at https://github.com/ceph/ceph-csi/releases and remove the static version from git entirely, or should we try and get a hook to have it happen at contribute time back to git? @rootfs

kfox1111 avatar Jan 28 '19 21:01 kfox1111

@Madhu-1 @wilmardo any thoughts here ?

humblec avatar Apr 01 '20 09:04 humblec

@Madhu-1 @wilmardo any thoughts here ?

this is one of the good feature to have it

Madhu-1 avatar Apr 01 '20 10:04 Madhu-1

Started this in #604 and I am willing to pick this back up. I will make some time coming Friday :)

wilmardo avatar Apr 01 '20 12:04 wilmardo

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 04 '20 10:10 stale[bot]

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

stale[bot] avatar Oct 12 '20 03:10 stale[bot]

#604 is still open and this issue hasn't been resolved just yet :'(

wilmardo avatar Oct 12 '20 09:10 wilmardo

can we check if we can use https://github.com/arttor/helmify to generate the helm charts from kubernetes objects?

Madhu-1 avatar Apr 02 '24 07:04 Madhu-1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 02 '24 21:05 github-actions[bot]

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

github-actions[bot] avatar May 10 '24 21:05 github-actions[bot]