ceph-container icon indicating copy to clipboard operation
ceph-container copied to clipboard

base: add sg3_utils package

Open guits opened this issue 2 years ago • 5 comments

This adds the sg3_utils package.

Signed-off-by: Guillaume Abrioux [email protected]

guits avatar Jun 01 '22 13:06 guits

What problem does this change solve?

Should Ceph's packages depend on this package?

ktdreyer avatar Jun 01 '22 13:06 ktdreyer

@ktdreyer the reason we need the package is the disk failure handling workflow. When a disk fails, and it's still seen by the kernel the current lsmcli integration works...but, when the device stops responding to test-unit-ready, the kernel drops the device node, which means the lsmcli integration no longer works. We know we see this on some of the external enclosures for example. By included sg3_utils we get access to sg_ses, which allows us to talk directly to the slot in the enclosure to activate the LED.

So getting sg3_utils included is the first step in improving our failed drive handling with external enclosures.

pcuzner avatar Jun 07 '22 06:06 pcuzner

Why doesn't ceph-volume or ceph-osd depend on it, in that case?

ktdreyer avatar Jun 17 '22 14:06 ktdreyer

@ktdreyer I personally don't mind pulling the package by dependency during the image build or installing it explicitly, as long as we end up with the package present in the image. Which option do we prefer?

guits avatar Aug 03 '22 02:08 guits

@ktdreyer I personally don't mind pulling the package by dependency during the image build or installing it explicitly, as long as we end up with the package present in the image. Which option do we prefer?

@ktdreyer ^

guits avatar Aug 10 '22 07:08 guits

Seems like we should put it into the RPM

ktdreyer avatar Sep 15 '22 20:09 ktdreyer