Use ceph-volume lvm deactivate to cleanup on sigterm

[mstinsky]

As of octopus the ceph-volume command has a deactivate option which implements what is done in the sigterm_cleanup_post function. This MR removes the current cleanup code and just does a ceph-volume lvm deactivate to unmount the lvs and close the crypts. This helps sharing code with ceph/ceph.

While implementing this I found a bug with ceph-volume lvm deactivate which prevents closing the dmcrypts, so this MR should be blocked until https://github.com/ceph/ceph/pull/45659 is resolved.

Also I am not really familiar with the repo structure and workflow I was reading a bit in the CONTRIBUTING.md and if I understand this correctly this MR would also need the old osd_disk_activate.sh inside ceph-releases/nautilus/daemon/osd_scenarios/ correct? Because this would not be compatible with nautilus.

[mstinsky]

Just figured that this MR as is breaks osds with simple setup. Not sure if we would want to restructure the if else statements to use ceph-volume lvm deactivate for lvm volumes and keep the old method for simple volumes or just keep everything as is. Any opinions?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.