ceph-chef icon indicating copy to clipboard operation
ceph-chef copied to clipboard

OSD devices should be specified by FQDN

Open rdgold94 opened this issue 7 years ago • 3 comments

In the osd.rb recipe, devices are specified by the following node attribute:

devices = node['ceph']['osd']['devices']

As long as each node that this recipe runs on has the exact same OSD device, this works correctly. However, in some cases, nodes running the osd recipe may have different specifications for its devices. For instance, one node might have a volume called "/dev/vdb":

"osd": {
  "devices": [
    {
      "data": "/dev/vdb",
      "journal": "/dev/vdb"
    }
  ]
}

While another node has a volume called "/dev/vdc":

"osd": {
  "devices": [
    {
      "data": "/dev/vdc",
      "journal": "/dev/vdc"
    }
  ]
}

Ideally, we should be able to qualify OSD devices by FQDN so that we don't need to update the attribute every time we have an OSD with a differently named/type of device:

"<FQDN>": {
  "devices": [
    {
      "data": "/dev/vdc",
      "journal": "/dev/vdc"
    }
  ]
}

rdgold94 avatar Jul 11 '17 00:07 rdgold94

I can see that but the initial thought was all nodes nodes would be similar configs. Could keep the default as is but add a fqdn attribute that would override the default for those that are different. I will take a look. Thanks

hanscj1 avatar Jul 14 '17 01:07 hanscj1

Or, issue a PR ;)

hanscj1 avatar Jul 14 '17 01:07 hanscj1

I've been doing some work with someone else on this cookbook, so you should see a pull request from them soon hopefully :)

rdgold94 avatar Jul 14 '17 01:07 rdgold94