ceph-build icon indicating copy to clipboard operation
ceph-build copied to clipboard

archiving Ceph's directories for the job 'ceph-pr-clang-tidy'

Open Suyashd999 opened this issue 1 year ago • 10 comments

The job ceph-pr-clang-tidy requires Ceph's build but since the job ceph-pull-requests is already building Ceph it is best to archive & copy the directory and work further upon it. It is done to save time and resources required to again build Ceph.

artifact required by: https://github.com/ceph/ceph-build/pull/2269

Suyashd999 avatar Aug 24 '24 12:08 Suyashd999

Can one of the admins verify this patch?

ceph-jenkins avatar Aug 24 '24 12:08 ceph-jenkins

  1. I think there's also some sort of permissions that need to be granted to the tidy job by the make check job to allow it to use the artifacts (see for example ceph-setup and job.properties.copyartifact) 2) how long does ceph-tidy take? Do we want it to run on every ceph make-check build?

dmick avatar Aug 28 '24 05:08 dmick

@dmick

  1. I think there's also some sort of permissions that need to be granted to the tidy job by the make check job to allow it to use the artifacts (see for example ceph-setup and job.properties.copyartifact)
  1. Yes we must allow Permission to Copy Artifact, I'll check it in the file mentioned by you.
  1. how long does ceph-tidy take?
  1. The clang-tidy would take a maximum of 15-20 minutes to complete execution.

Do we want it to run on every ceph make-check build?

Yes we must run after every make-check build.

Suyashd999 avatar Aug 28 '24 12:08 Suyashd999

Well, not "must", it, like everything, is a choice. Let me bring this up to the clt.

dmick avatar Aug 28 '24 18:08 dmick

Well, not "must", it, like everything, is a choice. Let me bring this up to the clt.

Okay no problem

Suyashd999 avatar Aug 28 '24 18:08 Suyashd999

think there's also some sort of permissions that need to be granted to the tidy job by the make check job to allow it to use the artifacts (see for example ceph-setup and job.properties.copyartifact)

Hi @dmick! I have added the code to give permission to our job ceph-pr-clang-tidy to copy artifacts from ceph-pull-requests Please do check.

Suyashd999 avatar Aug 28 '24 20:08 Suyashd999

Well, not "must", it, like everything, is a choice. Let me bring this up to the clt.

@dmick any update from clt?

Suyashd999 avatar Aug 30 '24 06:08 Suyashd999

does everything look good ? @dmick

Suyashd999 avatar Sep 02 '24 12:09 Suyashd999

I'm sorry we haven't made more progress with this. You've hit on an area of Ceph development that is not very flexible to new work right now. We're going to continue trying to move the discussion along.

dmick avatar Sep 05 '24 17:09 dmick

I'm sorry we haven't made more progress with this. You've hit on an area of Ceph development that is not very flexible to new work right now. We're going to continue trying to move the discussion along.

@dmick I see.. Please let me know what should I do from my end.

Suyashd999 avatar Sep 05 '24 19:09 Suyashd999