ceph-ansible icon indicating copy to clipboard operation
ceph-ansible copied to clipboard

library/rados_user.py modify

Open karasjoh000 opened this issue 2 years ago • 8 comments

https://github.com/ceph/ceph-ansible/blob/b40e4bfe60cb14a8eac225086f60d5b170636b6d/library/radosgw_user.py#L268-L269

If display_name != name and display_name is not provided as a param, then display_name is changed to name although the expectation will be that display_name should not change.

Note: I did not test this, but it seems that L268 and L269 need to be removed.

karasjoh000 avatar Aug 16 '22 18:08 karasjoh000

display_name is a mandatory parameter to radosgw-admin command. If you do not set the display_name, it fails creating the user with could not create user: unable to create user, no display name specified. This is probably why L268 and L269 are there for but indeed if the user already exists, its display_name will be overwritten with name.

Seems to be an easy fix, I will take a look at it. Thx

asm0deuz avatar Aug 18 '22 10:08 asm0deuz

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 02 '22 20:09 github-actions[bot]

Ill create a PR for this

karasjoh000 avatar Sep 06 '22 16:09 karasjoh000

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 21 '22 20:09 github-actions[bot]

@karasjoh000 what is the status on this? should we take over?

guits avatar Sep 22 '22 17:09 guits

@asm0deuz @karasjoh000 🙂

guits avatar Sep 28 '22 05:09 guits

This should be a 2 line fix I think.

karasjoh000 avatar Sep 28 '22 18:09 karasjoh000

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 13 '22 20:10 github-actions[bot]

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

github-actions[bot] avatar Oct 20 '22 20:10 github-actions[bot]