gstcefsrc icon indicating copy to clipboard operation
gstcefsrc copied to clipboard

Allow commas in chrome flags

Open frostbyte73 opened this issue 2 years ago • 3 comments

Before: gstcefsrc.SetProperty("chrome-extra-flags", "disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees")

Adding switch with value disable-features=site-per-process
Adding flag TranslateUI
Adding flag BlinkGenPropertyTrees

After: gstcefsrc.SetProperty("chrome-extra-flags", "disable-features=site-per-process|TranslateUI|BlinkGenPropertyTrees")

Adding switch with value disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees

frostbyte73 avatar Dec 16 '22 02:12 frostbyte73

Ah, I see, that's a bit of a bummer :( Are there any guarantees that | will indeed not occur in values ?

MathieuDuponchelle avatar Dec 16 '22 12:12 MathieuDuponchelle

Ah, I see, that's a bit of a bummer :( Are there any guarantees that | will indeed not occur in values ?

No guarantees, but generally the list flags are comma separated. I considered trying to escape the commas instead but my c++ is pretty rusty

frostbyte73 avatar Dec 19 '22 04:12 frostbyte73

I see. Would turning the property into an array of strings instead solve the issue?

MathieuDuponchelle avatar Dec 19 '22 11:12 MathieuDuponchelle