centreon-plugins icon indicating copy to clipboard operation
centreon-plugins copied to clipboard

Performance statistics Dell Powerstore Check

Open Hbitvof opened this issue 2 years ago • 22 comments

Hi,

Is it possible to add performance statistics to the Dell Powerstore check? Kind of the same as on the Dell Powervault checks. The most important part for us are latency statistics.

Hbitvof avatar Jun 27 '22 12:06 Hbitvof

Hi,

What kind of performance data? I assume you would expect it in hardware components.

If the API provides some data why not, but we will need curl and sample results to develop it.

Sims24 avatar Jun 27 '22 14:06 Sims24

For the Dell Powervault there is a controller statistics component and a volume statistics component. I would like to see the same for the Powerstore check, so not only performance data, but also checks on these data if everything is OK. So for example when there is too much latency we get an alert.

The API can provide all these data, when kind of input can I provide? Can I provide this private?

Hbitvof avatar Jun 28 '22 10:06 Hbitvof

Yes you can send it directly to:

Thanks

Sims24 avatar Jun 28 '22 11:06 Sims24

@Hbitvof could you give me the units for the following values ? (latency an bandwitdth)

"avg_write_latency": 381.44846,
"avg_read_bandwidth": 55678444,

garnier-quentin avatar Aug 01 '22 15:08 garnier-quentin

@Hbitvof could you give me the units for the following values ? (latency an bandwitdth)

"avg_write_latency": 381.44846,
"avg_read_bandwidth": 55678444,

Following the documentation that's: latency in microseconds bytes per second

Hbitvof avatar Aug 02 '22 12:08 Hbitvof

Thanks. It will be available thursday

garnier-quentin avatar Aug 02 '22 14:08 garnier-quentin

Could you test with that version ? https://github.com/centreon/centreon-plugins/archive/refs/heads/MON-14466-powerstore-performance.zip

garnier-quentin avatar Aug 04 '22 15:08 garnier-quentin

Could you test with that version ? https://github.com/centreon/centreon-plugins/archive/refs/heads/MON-14466-powerstore-performance.zip

Yes I can. What part is changed so I know how what commands I need to run?

Hbitvof avatar Aug 08 '22 08:08 Hbitvof

@Hbitvof with sources above, try the new --plugin=storage::dell::powerstore::restapi::plugin --mode=clusters that should answer to your request.

Sims24 avatar Aug 08 '22 09:08 Sims24

@Hbitvof with sources above, try the new --plugin=storage::dell::powerstore::restapi::plugin --mode=clusters that should answer to your request.

I get the following output when running the new part:

image

Hbitvof avatar Aug 08 '22 10:08 Hbitvof

could you provide the --debug result ?

garnier-quentin avatar Aug 08 '22 10:08 garnier-quentin

could you provide the --debug result ?

afbeelding

Hbitvof avatar Aug 08 '22 10:08 Hbitvof

It's weird. Other modes are working ? The curl command is working with endpoint: /api/rest/cluster ?

garnier-quentin avatar Aug 09 '22 08:08 garnier-quentin

It's weird. Other modes are working ? The curl command is working with endpoint: /api/rest/cluster ?

Apologies, I did something wrong. I tried it again with the right commandline and I get:

UNKNOWN: 405 Method Not Allowed

Hbitvof avatar Aug 11 '22 09:08 Hbitvof

Could you provide the --debug ?

garnier-quentin avatar Aug 11 '22 09:08 garnier-quentin

Could you provide the --debug ?

afbeelding

Hbitvof avatar Aug 11 '22 09:08 Hbitvof

I think I know what the problem is. Method should be POST instead of GET for /api/rest/metrics/generate

Hbitvof avatar Aug 11 '22 10:08 Hbitvof

Could you redownload it and test it ? (i have done a patch)

garnier-quentin avatar Aug 11 '22 11:08 garnier-quentin

Could you redownload it and test it ? (i have done a patch)

Can you provide a download link again? I just downloaded it again from https://github.com/centreon/centreon-plugins/archive/refs/heads/MON-14466-powerstore-performance.zip but got the same error.

Hbitvof avatar Aug 11 '22 13:08 Hbitvof

It's the good link:

https://github.com/centreon/centreon-plugins/archive/refs/heads/MON-14466-powerstore-performance.zip

Could you provide the --debug ? (it should be a POST).

garnier-quentin avatar Aug 11 '22 14:08 garnier-quentin

I get another error now:

afbeelding

Hbitvof avatar Aug 11 '22 14:08 Hbitvof

It's better :) You can redownload it and retest it ? (i have a done a new patch)

garnier-quentin avatar Aug 11 '22 14:08 garnier-quentin

The check is working now!

I only see some strange output in the performance data:

afbeelding

How can I set warning/critical thresholds for this check?

Hbitvof avatar Aug 15 '22 07:08 Hbitvof

I have removed the microseconds units. Thresholds are in the help:

=item B<--warning-*> B<--critical-*>

Thresholds.
Can be: 'clusters-detected',
'read-iops-5m', 'read-iops-30m', 'read-iops-1h', 'read-iops-24h',
'write-iops-5m', 'write-iops-30m', 'write-iops-1h', 'write-iops-24h',
'read-latency-5m', 'read-latency-30m', 'read-latency-1h', 'read-latency-24h',
'write-latency-5m', 'write-latency-30m', 'write-latency-1h', 'write-latency-24h',
'read-bandwidth-5m', 'read-bandwidth-30m', 'read-bandwidth-1h', 'read-bandwidth-24h',
'write-bandwidth-5m', 'write-bandwidth-30m', 'write-bandwidth-1h', 'write-bandwidth-24h'.

garnier-quentin avatar Aug 16 '22 07:08 garnier-quentin

I have removed the microseconds units. Thresholds are in the help:

=item B<--warning-*> B<--critical-*>

Thresholds.
Can be: 'clusters-detected',
'read-iops-5m', 'read-iops-30m', 'read-iops-1h', 'read-iops-24h',
'write-iops-5m', 'write-iops-30m', 'write-iops-1h', 'write-iops-24h',
'read-latency-5m', 'read-latency-30m', 'read-latency-1h', 'read-latency-24h',
'write-latency-5m', 'write-latency-30m', 'write-latency-1h', 'write-latency-24h',
'read-bandwidth-5m', 'read-bandwidth-30m', 'read-bandwidth-1h', 'read-bandwidth-24h',
'write-bandwidth-5m', 'write-bandwidth-30m', 'write-bandwidth-1h', 'write-bandwidth-24h'.

Thanks for your quick actions!

Is it possible to convert the microsecond units to miliseconds? That's more common in storage performance counters.

Hbitvof avatar Aug 16 '22 08:08 Hbitvof

Yes i will update it

garnier-quentin avatar Aug 16 '22 08:08 garnier-quentin

It's merged!

garnier-quentin avatar Aug 16 '22 11:08 garnier-quentin

It's merged!

I think you forgot to convert the output (/1000) :).

Hbitvof avatar Aug 16 '22 14:08 Hbitvof

It should be done: https://github.com/centreon/centreon-plugins/pull/3838/files#diff-29f6c085963d5cf9ad2e222b9f080ad492476c4896ff21e13175e29cc8e9b351R227

garnier-quentin avatar Aug 16 '22 15:08 garnier-quentin

It should be done: https://github.com/centreon/centreon-plugins/pull/3838/files#diff-29f6c085963d5cf9ad2e222b9f080ad492476c4896ff21e13175e29cc8e9b351R227

Well, it doesn't seem to work (we don't have this latency on our storage :)):

image

Hbitvof avatar Aug 22 '22 06:08 Hbitvof