centreon-archived icon indicating copy to clipboard operation
centreon-archived copied to clipboard

Published 20 hours ago • verified publisher icon centreon

Added hide custom view functionality

Open alfredosilvestre-natixis opened this issue 4 years ago • 6 comments

Description

This new functionality allows to hide a custom view without deleting it.

It is useful if you want to cleanup your custom views list that you shared without having to delete them.

It also adds clarity by having a clear distinction between the action for hiding a view and for deleting a view because currently there is only a "Delete view" button.

Fixes #4721

Type of change

  • [ ] Patch fixing an issue (non-breaking change)
  • [X] New functionality (non-breaking change)
  • [ ] Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • [ ] Updating documentation (missing information, typo...)

Target serie

  • [ ] 19.04.x
  • [ ] 19.10.x
  • [ ] 20.04.x
  • [X] 20.10.x (master)

How this pull request can be tested ?

  1. Open the custom views page
  2. Create a new view or add an existing one
  3. If a new view was created, both the "Delete view" and "Hide view" buttons are active
  4. If an existing view was added, only the "Hide view" button is active

Checklist

  • [X] I followed the coding style guidelines provided by Centreon
  • [X] I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • [X] I have commented my code, especially hard-to-understand areas of the PR.
  • [ ] I have made corresponding changes to the documentation.
  • [X] I have rebased my development branch on the base branch (master, maintenance).

alfredosilvestre-natixis avatar Sep 10 '20 21:09 alfredosilvestre-natixis

Hi @alfredosilvestre-natixis, Thanks for this PR too. I'll let @kduret and @adr-mo take a look at this one before it enters our backlog. As it's a new feature, it could (unfortunately) only reach the master branch.

cgagnaire avatar Sep 11 '20 09:09 cgagnaire

Hello,

I can't see why the build has failed since it looks like I can't connect to the jenkins url.

On my test platform it working correctly.

alfredosilvestre-natixis avatar Sep 11 '20 09:09 alfredosilvestre-natixis

Don't worry, we will manage the build.

cgagnaire avatar Sep 11 '20 09:09 cgagnaire

LGTM But we need to test lot of use cases to check if everything works fine. particularly, this use case : hide, then show a hidden view (add share view ?)

kduret avatar Sep 24 '20 07:09 kduret

I accidentally removed my fork repository while trying to fix it, so I don't know if it is possible to add more commits to this PR.

I left a comment because there was a bug when removing the view the widget_preferences are not removed

alfredosilvestre-natixis avatar Dec 15 '20 13:12 alfredosilvestre-natixis

Hi @alfredosilvestre-natixis we have a new process regarding the implementation of new features, we submit the idea on "The Watch" and if this improvement idea wins enough votes, we can retain it, prioritize it, etc.

Your idea has been submitted on "Tha watch" and is currently awaiting some vote https://thewatch.centreon.com/ideas/add-hide-functionality-to-custom-views-1032 best regards Baptiste

Barbeloa avatar Sep 26 '22 12:09 Barbeloa