opencensus-specs icon indicating copy to clipboard operation
opencensus-specs copied to clipboard

Attributes and Links limit may be exporter concern, not the runtime

Open SergeyKanzhelev opened this issue 7 years ago • 4 comments

In Java implementation limits of attributes and links is a runtime concern. API wouldn't allow to create more then limit number of attributes.

However this approach will always call into issues like https://github.com/census-instrumentation/opencensus-specs/issues/226. Perhaps these limits can be a config setting of exporter.

Proto doesn't define any limit on either of those so limits seems to be arbitrary.

SergeyKanzhelev avatar Jan 16 '19 21:01 SergeyKanzhelev

Do you suggest to remove any limitation on the runtime implementation and allow exporters to do whatever they consider?

bogdandrutu avatar Jan 29 '19 04:01 bogdandrutu

Yes. Is the need for runtime check is to protect from abuse of an API?

SergeyKanzhelev avatar Jan 29 '19 16:01 SergeyKanzhelev

It seems better to leave that to exporters and also agent/collector that can be configured to do something intelligent about that (select, drop, trim, provide observability for data dropped etc).

pjanotti avatar Jan 31 '19 17:01 pjanotti

Agreed -- one of the design decisions for OC service was to set and forget client libraries, but with the current implementation that is not possible (already aware of someone who hit the limit and then had to reconfigure the client).

flands avatar Feb 01 '19 03:02 flands