opencensus-python icon indicating copy to clipboard operation
opencensus-python copied to clipboard

Added RPC Measure and View Constants

Open aasiyahf opened this issue 5 years ago • 7 comments

We (myself and @anamnavi) have been working on resolving issue #276 alongside Microsoft's Quantum Computing Team for code review, quality control, etc. in relation to RPC zpages written in Python.

As per the requirements of the opencensus specs document, we implemented the RPC View and Measure Constants. You can find them within opencensus/grpc under the names rpc_measure_constants.py and rpc_view_constants.py. We have included test files under the names rpc_m_c_test.py and rpc_v_c_test.py, respectively.

For further inquiry, you can reach me at [email protected] or [email protected] and @anamnavi at [email protected] or [email protected].

aasiyahf avatar Apr 30 '20 20:04 aasiyahf

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot avatar Apr 30 '20 20:04 googlebot

@googlebot I consent

anamnavi avatar Apr 30 '20 20:04 anamnavi

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Apr 30 '20 20:04 googlebot

@songy23 @c24t @reyang Hi all, I'm the MSFT contact that was working with these students on a senior design project with this as one of the outputs (Hi @reyang , we met last summer). They've officially finished their projects, so I'm trying to help them push their changes through into the repo. It looks to me that they've cleaned up the code here, and it's unclear why the travis build is failing on a unit test.

Can you help let us know if we need to do anything for that particular build/test?

cdietschrun avatar May 01 '20 18:05 cdietschrun

2 week ping, would love to drive this one through if at all possible, if anything's needed on our side, since the authors have graduated by now.

cdietschrun avatar May 14 '20 16:05 cdietschrun

@cdietschrun Try rebasing and see if the error is still there.

lzchen avatar Jun 29 '20 18:06 lzchen

Looks clean now

cdietschrun avatar Oct 08 '20 20:10 cdietschrun