opencensus-python icon indicating copy to clipboard operation
opencensus-python copied to clipboard

Published 20 hours ago • verified publisher icon census-instrumentation

Don't enable sampling by default

Open c24t opened this issue 6 years ago • 0 comments

This is a WIP PR to disable sampling using default trace options. This started as a drive-by fix to replace a string-valued bit field with an int and expanded as I compared TraceOptions and SpanContext to their counterparts in java.

@liyanhui1228 I'd appreciate some comments here since it's not obvious that sampling shouldn't be enabled by default, and there are a few design choices here I don't understand.

Addresses #481.

c24t avatar Feb 05 '19 20:02 c24t