opencensus-python icon indicating copy to clipboard operation
opencensus-python copied to clipboard

Add ability to pass auxiliary attributes to set on GRPC trace

Open tab1293 opened this issue 5 years ago • 4 comments

Overview

Support an optional aux_attributes parameter to OpenCensusClientInterceptor constructor in order to allow users to specify arbitrary tags on GRPC method trace spans.

tab1293 avatar Oct 29 '18 19:10 tab1293

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Oct 29 '18 19:10 googlebot

I have just signed the CLA

tab1293 avatar Oct 29 '18 19:10 tab1293

CLAs look good, thanks!

googlebot avatar Oct 29 '18 19:10 googlebot

+1 for this, I'd rename those to extra_attributes instead of aux_attributes.

ocervell avatar Nov 01 '18 19:11 ocervell