opencensus-python icon indicating copy to clipboard operation
opencensus-python copied to clipboard

Published 20 hours ago • verified publisher icon census-instrumentation

Add FastAPI extension

Open ikait opened this issue 3 years ago • 4 comments

closes https://github.com/census-instrumentation/opencensus-python/issues/1020

This PR adds the FastAPI extension into contrib dir. Just like the stackdriver extension, it targets py3.6 and above that FastAPI supports.

ikait avatar May 03 '22 17:05 ikait

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar May 03 '22 17:05 google-cla[bot]

Would like to see this merged at some point. Thank you

KDmytro avatar Jul 13 '22 22:07 KDmytro

The MSFT example is so bad for this. It doesn't even populate operation_name on the performance view of AI. This is a must have IMO.

jabbera avatar Oct 10 '22 19:10 jabbera

Wondering what is wrong with this PR/. There are no comments by any reviwers

pkt1583 avatar Oct 11 '22 12:10 pkt1583

Yes, this should be reviewed. My guess is that folks just copy+paste this code into their own project atm.

calleo avatar Jan 25 '23 08:01 calleo

Hi @ikait 👋 Can rebase it with current master? There certainly will be a conflict in _Integrations, because of recently added httpx extension. I'm deeply interested in getting that merged too.

Just by looking at the code I love your solution and it should work perfectly, but I'm not a maintainer, so my opinion doesn't really matter in the end.

Let me mention @lzchen and @jeremydvoss - I hope they will find time to review it and help you with merging.

nhtgl avatar Jan 25 '23 12:01 nhtgl

ok, I'll do it soon.

ikait avatar Jan 25 '23 12:01 ikait

Hi @lzchen and @jeremydvoss, I'm waiting for your code reviews. Thank you

ikait avatar Jan 29 '23 07:01 ikait

@ikait

Thanks for the contribution and apologies for the delay. I've left a couple of small comments. Please also fix the lint to get the builds to pass.

lzchen avatar Jan 31 '23 18:01 lzchen

@aabmass

lzchen avatar Jan 31 '23 18:01 lzchen

Thanks for your review. I have corrected the points you raised.

@lzchen Maybe your CLA is missing and the build is failing. Could you sign it? or should I rebase it?

ikait avatar Feb 27 '23 16:02 ikait

@ikait

Oops sorry about that, probably made the commit suggestions with a different email. I've signed the CLA but might take a bit to reflect in the build. In the meantime if you want to get this PR merged feel free to rebase my suggested changes.

Also please fix the failing tests.

lzchen avatar Feb 27 '23 18:02 lzchen

Thank you @lzchen, CLA passed and I fixed that test passed!

ikait avatar Mar 01 '23 14:03 ikait

@ikait I think tests are still failing. Are the tests passing locally? Please fix lint issues too. Sorry for the back and forth, I have to run the builds manually haha.

lzchen avatar Mar 01 '23 19:03 lzchen

Hi @lzchen, I fixed lint issues and confirmed tox passed locally.

ikait avatar Mar 08 '23 16:03 ikait

@ikait

Awesome! Thanks for the great work! Will be releasing this soon.

lzchen avatar Mar 09 '23 17:03 lzchen

@lzchen when can we expect the release?

nhtgl avatar Mar 10 '23 12:03 nhtgl

@macieyng

https://pypi.org/project/opencensus-ext-fastapi/0.1.0/

lzchen avatar Mar 10 '23 19:03 lzchen

Thank you @ikait ♥️ Thank you @lzchen ♥️ You made some people in Poland happy today! 😇🙃

nhtgl avatar Mar 10 '23 19:03 nhtgl