opencensus-python icon indicating copy to clipboard operation
opencensus-python copied to clipboard

Published 20 hours ago • verified publisher icon census-instrumentation

Added support for Flask 2. Setup.py-dependency bumped to < 3.0.0. Closes #1022

Open mortendaehli opened this issue 3 years ago • 16 comments

FlaskMiddleware is compatible with Flask 2. The dependency is thus bumped in setup.py to < 3.0.0.

Closes #1022

mortendaehli avatar Sep 01 '21 18:09 mortendaehli

By the way, this is my first open source PR. Please let me know if I should do anything different, or if you have any advice. I have read the contributing guidelines and the code of conduct and tried to follow doing my best :)

mortendaehli avatar Sep 01 '21 18:09 mortendaehli

@aabmass, could you please review this?

mortendaehli avatar Sep 17 '21 07:09 mortendaehli

I was just about to make a PR for this and I'm glad I found one already open!

This is desperately needed, it causes havoc on dependency resolution between popular packages that rely on flask:

The conflict is caused by:
    The user requested flask==2.0.0
    flask-smorest 0.34.0 depends on flask<3 and >=2.0
    flask-sqlalchemy 2.5.0 depends on Flask>=0.10
    flask-marshmallow 0.13.0 depends on Flask
    opencensus-ext-flask 0.7.5 depends on flask!=1.1.3, <2.0.0 and >=0.12.3

Maybe one for @lzchen

jamescw avatar Sep 22 '21 16:09 jamescw

@lzchen Could this be merged? 🙏🏼

aberres avatar Oct 25 '21 14:10 aberres

I have updated the PR to solve a merge conflict.

mortendaehli avatar Oct 26 '21 11:10 mortendaehli

Any idea about the python 3.5 error? Is it related to flask 2 only supporting python3.7+?

aabmass avatar Nov 16 '21 20:11 aabmass

Could this be merged? 🙏🏼

jo47011 avatar Dec 09 '21 16:12 jo47011

Flask 2 does not support Python 3.5. Any chance we could drop Python 3.5? It reached end of life more than 1 year ago.

mortendaehli avatar Dec 16 '21 19:12 mortendaehli

Any news on this issue? We would really appreciate the merge as our security scanner forces us to disable this package until then :( Thanks a lot.

jo47011 avatar Feb 03 '22 14:02 jo47011

+1 any preview to release new package allowing to use with flask 2?

gabrieligbastos avatar Feb 08 '22 20:02 gabrieligbastos

Ping. Any update on this?

gabloe avatar Mar 14 '22 18:03 gabloe

Ping. We would be very interested in an update here as we are not able to use the new awesome Flask version with support for multi threading.

louisbergmann avatar Apr 01 '22 16:04 louisbergmann

Same, desperately waiting for this PR to be merged and released

jonasmiederer avatar Apr 07 '22 09:04 jonasmiederer

This is also blocking us at the moment.

QuintenDV avatar Apr 11 '22 07:04 QuintenDV

Any news here? what's happening on the py35 build?

danielsbarros avatar Apr 15 '22 00:04 danielsbarros

@mortendaehli Could you rebase and modify the tox file to not test on Py3.5?

lzchen avatar Apr 15 '22 17:04 lzchen