opencensus-python icon indicating copy to clipboard operation
opencensus-python copied to clipboard

Added aiohttp integration

Open maciejmoskala opened this issue 4 years ago • 10 comments

Aiohttp integration to track async requests. Library way build based on opencensus-ext-requests and it was tested on real life environment.

maciejmoskala avatar May 13 '21 09:05 maciejmoskala

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar May 13 '21 09:05 google-cla[bot]

@googlebot I signed it!

maciejmoskala avatar May 13 '21 09:05 maciejmoskala

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar May 13 '21 09:05 google-cla[bot]

@googlebot I fixed it.

maciejmoskala avatar May 13 '21 10:05 maciejmoskala

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar May 13 '21 10:05 google-cla[bot]

@aabmass @hectorhdzg @lzchen @songy23 What I should do to make this PR approved? Is there any flow I need to follow?

maciejmoskala avatar Jun 01 '21 06:06 maciejmoskala

@lzchen What should I do to make this PR to be added to project and to have package released?

maciejmoskala avatar Aug 16 '21 14:08 maciejmoskala

@maciejmoskala

Thanks for the contribution and sorry for the long wait in reviewing. In terms of integration contributions, we expect contributors to maintain this part of the codebase in the future. OpenCensus maintainers will assist when needed by the responsibility for maintaining, reviewing issues/PRs and releasing related to this integration falls on the contributor. Is this alright with you?

lzchen avatar Aug 16 '21 17:08 lzchen

Can I please ask if this is abandoned?

polys avatar Nov 29 '21 11:11 polys

@maciejmoskala Are you still working on this PR?

lzchen avatar Nov 30 '21 18:11 lzchen