opencensus-node
opencensus-node copied to clipboard
Fix circular import
This PR fixes the circular import problems occurring when you load http2
or https
module before http
module.
For example, the following code reproduces a problem @opencensus-instrumentation-http
module doesn't load properly.
const tracing = require('@opencensus/nodejs');
const zipkin = require('@opencensus/exporter-zipkin');
const assert = require('assert');
const tracer = tracing.start({samplingRate: 1.0}).tracer;
const https = require('https');
const http = require('http');
tracer.registerSpanEventListener(new zipkin.ZipkinTraceExporter({
url: 'http://localhost:9411/api/v2/spans',
serviceName: 'node.js-open-census-bug'
}));
http.get('http://example.com/', (res) => {
res.setEncoding('utf8');
let rawData = '';
res.on('data', (chunk) => { rawData += chunk; });
res.on('end', () => {
console.log(rawData);
});
});
The process of problem is as follows schematically:
- Load
http2
module. -
require-in-the-middle
load@opencensus-instrumentation-http2
module. -
@opencensus-instrumentation-http2
load@opencensus-instrumentation-http
module. -
@opencensus-instrumentation-http
loadhttp
. -
require-in-the-middle
try to load@opencensus-instrumentation-http
, but loading of@opencensus-instrumentation-http
is already in progress. Therefore require statement return partial@opencensus-instrumentation-http
. - The problem happens.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
@draffensperger and @hekike what do you think about this?