opencensus-go icon indicating copy to clipboard operation
opencensus-go copied to clipboard

exporter/jaeger: Links are missing LinkType

Open odeke-em opened this issue 5 years ago • 6 comments

We need the ability to translate a span's LinkType to a jaeger RefType.

It currently is https://github.com/census-instrumentation/opencensus-go/blob/94fd1d08391b28f9c9f721b2a67fcf57bfd0a70e/exporter/jaeger/jaeger.go#L214-L220

But needs to translate *SpanData.Links[].Type i.e.

for _, link := range data.Links { 
 	refs = append(refs, &gen.SpanRef{ 
 		TraceIdHigh: bytesToInt64(link.TraceID[0:8]), 
 		TraceIdLow:  bytesToInt64(link.TraceID[8:16]), 
 		SpanId:      bytesToInt64(link.SpanID[:]), 
                 RefType: asJaegerLinkType(link.Type),
 	}) 
 } 

func asJaegerLinkType(t LinkTypeChild) SpanRefType {
        if t == LinkTypeChild {
           return gen.SpanRefType_CHILD_OF
        }
        // Other OpenCensus LinkTypes don't map to Jaeger's LinkTypes
        // TODO: file an issue with Jaeger and ask about the various LinkTypes
        return gen.SpanRefType_FOLLOWS_FROM
} 

odeke-em avatar Nov 12 '18 07:11 odeke-em

@rghetia Shall I take up this issue?

rajcspsg avatar Jan 18 '20 15:01 rajcspsg

@rghetia Shall I take up this issue?

sure.

rghetia avatar Jan 21 '20 17:01 rghetia

Is this issue still of interest?

djui avatar Sep 29 '20 11:09 djui

@djui Yeah But I couldn't find the file jaeger.go in master branch. Any idea on this?

rajcspsg avatar Oct 01 '20 00:10 rajcspsg

Hi @rghetia is it still relevant and ready to be picked. If yes, I would love to take it up.

kaustubhmallik avatar Jan 19 '22 16:01 kaustubhmallik

@kaustubhmallik I would recommend getting involved in OpenTelemetry instead.

punya avatar Jan 19 '22 16:01 punya