opencensus-go icon indicating copy to clipboard operation
opencensus-go copied to clipboard

zPages: Improve the color and style to be consistent with Java.

Open songy23 opened this issue 5 years ago • 2 comments

@adamgarza has done a bunch of improvements on the Java zPages, and now the zPages look like this: https://github.com/census-instrumentation/opencensus-java/tree/master/contrib/zpages#view-stats-and-spans-on-z-pages.

We should apply the same color and style to zPages in Go.

songy23 avatar Oct 18 '18 16:10 songy23

Can we extract the CSS+HTML and reuse it rather than hard coding it again?

semistrict avatar Oct 19 '18 17:10 semistrict

In Java we found it's difficult to use a css file so we stored the styling in a Java string: https://github.com/census-instrumentation/opencensus-java/blob/master/contrib/zpages/src/main/java/io/opencensus/contrib/zpages/Style.java#L22

It should be trivial to just extract the styles and reuse them in a css file.

songy23 avatar Oct 19 '18 17:10 songy23