opencensus-go icon indicating copy to clipboard operation
opencensus-go copied to clipboard

Enforce tag equivalence in `view.same()`

Open rubensf opened this issue 1 year ago • 3 comments

Otherwise, the lack of error may lead to developers wasting a lot of time trying to figure out why do their labels not show up.

rubensf avatar Jul 27 '22 21:07 rubensf

He @rubensf! Right now we are only accepting security fixes or critical bug fixes. Can you say more about the issue this fixes?

dashpole avatar Jul 28 '22 12:07 dashpole

Ah, I didn't notice this repo was being phased out. The problem here is that the check for two views being the same, in my semantic understanding, is incorrect - it currently returns that two views are the same even though they may have different tags.

This is an issue if you eg use zpages which registers some views at init(), or if you generally have a large enough codebase and register views in multiple spots. You can technically Unregister them and Register new ones, but if you're not very familiar with your codebase you may spend a few hours (as I did) trying to find out why your views with different tags are not showing up on your metrics... :)

That'd def be a behaviour change. I'm not sure if you'd count it as a critical bug fix though so feel free to close it.

rubensf avatar Jul 28 '22 14:07 rubensf

Thanks for your understanding. If others hit this issue we can reconsider it, but i'll close it for now. Hopefully your workaround will save them some time.

dashpole avatar Jul 28 '22 15:07 dashpole