opencensus-go icon indicating copy to clipboard operation
opencensus-go copied to clipboard

Convert 500 http status code to trace status code Internal

Open OmarElgabry opened this issue 4 years ago • 3 comments

Is there any reason why we aren't converting http status code (500) to a trace.Status code? The http.StatusInternalServerError has a corresponding trace status code trace.StatusCodeInternal

OmarElgabry avatar Sep 07 '20 19:09 OmarElgabry

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Sep 07 '20 19:09 googlebot

@googlebot I signed it!

OmarElgabry avatar Sep 07 '20 19:09 OmarElgabry

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Sep 07 '20 19:09 googlebot