opencensus-go icon indicating copy to clipboard operation
opencensus-go copied to clipboard

ochttp.Transport default span name is likely to be high cardinality

Open MatthewDolan opened this issue 5 years ago • 0 comments

The default span name for the ochttp.Transport plugin uses the path from the url (https://github.com/census-instrumentation/opencensus-go/blob/v0.22.1/plugin/ochttp/trace.go#L149-L151). Paths often contain unique identifier for resources (for example the gcs client path contains the object identifier https://github.com/googleapis/google-cloud-go/issues/1573).

It might be better to go with a safer default (like method which has a bounded cardinality). This might be related to https://github.com/census-instrumentation/opencensus-go/issues/932.

What version of OpenCensus are you using?

v0.22.1

What version of Go are you using?

go1.13.1

What did you do?

Used the default ochttp.Transport.

What did you expect to see?

Low cardinality span names.

What did you see instead?

Span names that contained unique identifiers.

Additional context

Add any other context about the problem here.

MatthewDolan avatar Oct 18 '19 16:10 MatthewDolan