opencensus-go icon indicating copy to clipboard operation
opencensus-go copied to clipboard

wrong metric for ServerResponseCountByStatusCode view

Open rjeczalik opened this issue 5 years ago • 1 comments

https://github.com/census-instrumentation/opencensus-go/blob/6ddd4bcc9c808594ec82377ce4323c3f7913be6d/plugin/ochttp/stats.go#L263-L269

The ServerLatency metric seems wrong, since there's no ServerResponseCount metric defined nor used. Given that I guess the view was meant to be ServerRequestCountByStatusCode.

Since server latency by status code feels like not that useful view, I was wondering whether ServerResponseCountByStatusCode should be replaced by ServerRequestCountByStatusCode:

	ServerRequestCountByStatusCode = &view.View{
		Name:        "opencensus.io/http/server/request_count_by_status_code",
		Description: "Server request count by status code",
		TagKeys:     []tag.Key{StatusCode},
		Measure:     ServerRequestCount,
		Aggregation: view.Count(),
	}

rjeczalik avatar Sep 04 '19 09:09 rjeczalik

Looks like the same issue as #995...

bvwells avatar Sep 04 '19 21:09 bvwells