opencensus-go
opencensus-go copied to clipboard
census-instrumentation
Add get data of span method
return the data of span to allow accessing all info of a span. just return the value of data instead a pointer to avoid changing by user. in order to solve #1007 .
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
As explained in #1007 there is no need to provide access to the entire span data payload for correlation purposes. This is what SpanContext is for. The other problem is you return a shallow copy of span data which would allow for mutating for instance the Attributes map (and get some concurrent access nasties). For now, I do not see a reason for allowing access to even a full copy of span data.
Why do we need to give SetForceGenerateSpanData as an option to the user?
@bogdandrutu, do we have any requirements about immutability of the span data?
As explained in #1007 there is no need to provide access to the entire span data payload for correlation purposes. This is what SpanContext is for. The other problem is you return a shallow copy of span data which would allow for mutating for instance the Attributes map (and get some concurrent access nasties). For now, I do not see a reason for allowing access to even a full copy of span data.
but i cann't get parent span id from SpanContext, could add a parent span id to the SpanContext?
